Wikunia / ConstraintSolver.jl

ConstraintSolver in Julia: Blog posts ->
https://opensourc.es/blog/constraint-solver-1
MIT License
136 stars 14 forks source link

Removed weird num_backtrack_obj #190

Closed Wikunia closed 3 years ago

Wikunia commented 3 years ago

Every BacktrackObj that gets created and added will be at the position of its backtrack_id. For checking how many backtrack objects exist we can simply use the length function.

I don't know why I did something else before :smiley:

codecov[bot] commented 3 years ago

Codecov Report

Merging #190 (24b22c7) into master (de7c5da) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   96.63%   96.63%   -0.01%     
==========================================
  Files          34       34              
  Lines        2854     2851       -3     
==========================================
- Hits         2758     2755       -3     
  Misses         96       96              
Impacted Files Coverage Δ
src/types.jl 100.00% <ø> (ø)
src/ConstraintSolver.jl 99.33% <100.00%> (-0.02%) :arrow_down:
src/type_inits.jl 94.28% <100.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de7c5da...24b22c7. Read the comment docs.

Wikunia commented 3 years ago

Benchmark Report for ConstraintSolver

Job Properties

Results

A ratio greater than 1.0 denotes a possible regression (marked with :x:), while a ratio less than 1.0 denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds).

ID time ratio memory ratio

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

Julia versioninfo

Target

Julia Version 1.5.0
Commit 96786e22cc (2020-08-01 23:44 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      "Arch Linux"
  uname: Linux 5.9.10-arch1-1 #1 SMP PREEMPT Sun, 22 Nov 2020 14:16:59 +0000 x86_64 unknown
  CPU: Intel(R) Xeon(R) CPU E5-1650 0 @ 3.20GHz: 
                 speed         user         nice          sys         idle          irq
       #1-12  1810 MHz     205165 s        749 s      20151 s   15840531 s       2512 s

  Memory: 46.98863983154297 GB (43622.84375 MB free)
  Uptime: 13398.0 sec
  Load Avg:  1.212890625  1.15869140625  0.80908203125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, sandybridge)

Baseline

Julia Version 1.5.0
Commit 96786e22cc (2020-08-01 23:44 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      "Arch Linux"
  uname: Linux 5.9.10-arch1-1 #1 SMP PREEMPT Sun, 22 Nov 2020 14:16:59 +0000 x86_64 unknown
  CPU: Intel(R) Xeon(R) CPU E5-1650 0 @ 3.20GHz: 
                 speed         user         nice          sys         idle          irq
       #1-12  1834 MHz     270971 s        749 s      22411 s   16578472 s       2678 s

  Memory: 46.98863983154297 GB (43675.75 MB free)
  Uptime: 14071.0 sec
  Load Avg:  1.05126953125  1.13525390625  1.00537109375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, sandybridge)