Wikunia / ConstraintSolver.jl

ConstraintSolver in Julia: Blog posts ->
https://opensourc.es/blog/constraint-solver-1
MIT License
136 stars 14 forks source link

Feature strict inequality #236

Closed Wikunia closed 3 years ago

Wikunia commented 3 years ago

Support for < and > which is sometimes easier for the modeler to write. This is also one small step towards #222

The general approach is to use the same code as for <= and translate them internally. Currently the rhs is only strong if all coefficients are -1 or 1 for the other cases see point 2:

codecov[bot] commented 3 years ago

Codecov Report

Merging #236 (c3dbecf) into master (6f71610) will increase coverage by 0.15%. The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   96.37%   96.53%   +0.15%     
==========================================
  Files          39       39              
  Lines        3340     3407      +67     
==========================================
+ Hits         3219     3289      +70     
+ Misses        121      118       -3     
Impacted Files Coverage Δ
src/type_inits.jl 94.73% <ø> (ø)
src/MOI_wrapper/Bridges/strictly_greater_than.jl 66.66% <66.66%> (ø)
src/types.jl 77.17% <75.00%> (-0.10%) :arrow_down:
src/constraints/linear_constraints.jl 97.05% <94.59%> (-0.50%) :arrow_down:
src/ConstraintSolver.jl 99.08% <100.00%> (+0.59%) :arrow_up:
src/MOI_wrapper/Bridges/indicator.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/Bridges/reified.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/MOI_wrapper.jl 92.30% <100.00%> (+0.50%) :arrow_up:
src/MOI_wrapper/constraints.jl 100.00% <100.00%> (ø)
src/MOI_wrapper/variables.jl 99.46% <100.00%> (+0.01%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f71610...c3dbecf. Read the comment docs.