Wikunia / ConstraintSolver.jl

ConstraintSolver in Julia: Blog posts ->
https://opensourc.es/blog/constraint-solver-1
MIT License
136 stars 13 forks source link

bugfix in still feasible reified constraint #246

Closed Wikunia closed 3 years ago

Wikunia commented 3 years ago

Check for two inactive cases:

codecov[bot] commented 3 years ago

Codecov Report

Merging #246 (2922ecc) into master (fe603b5) will decrease coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   96.56%   96.51%   -0.06%     
==========================================
  Files          39       39              
  Lines        3439     3440       +1     
==========================================
- Hits         3321     3320       -1     
- Misses        118      120       +2     
Impacted Files Coverage Δ
src/constraints/reified.jl 100.00% <100.00%> (ø)
src/ConstraintSolver.jl 98.48% <0.00%> (-0.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe603b5...2922ecc. Read the comment docs.

Wikunia commented 3 years ago

Benchmark Report for ConstraintSolver

Job Properties

Results

A ratio greater than 1.0 denotes a possible regression (marked with :x:), while a ratio less than 1.0 denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds).

ID time ratio memory ratio
["eternity", "5x5_all"] 1.30 (5%) :x: 1.00 (1%)
["eternity", "5x5_opt"] 1.29 (5%) :x: 1.00 (1%)
["eternity", "5x5_opt_ind"] 1.27 (5%) :x: 1.00 (1%)
["eternity", "5x5_opt_rei"] 1.27 (5%) :x: 1.00 (1%)
["eternity", "6x5_ABS"] 0.93 (5%) :white_check_mark: 1.00 (1%)
["graph_coloring", "US_50colors"] 1.08 (5%) :x: 1.00 (1%)
["graph_coloring", "US_8+equal"] 1.13 (5%) :x: 1.00 (1%)
["graph_coloring", "US_8+equal_ABS"] 1.05 (5%) :x: 1.00 (1%)
["graph_coloring", "queen7_7"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["killer_sudoku", "niall_5500"] 0.94 (5%) :white_check_mark: 1.00 (1%)
["killer_sudoku", "niall_5500_special"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["killer_sudoku", "niall_5501"] 0.90 (5%) :white_check_mark: 1.00 (1%)
["killer_sudoku", "niall_5501_ABS"] 1.05 (5%) 1.11 (1%) :x:
["killer_sudoku", "niall_5501_special"] 0.89 (5%) :white_check_mark: 1.00 (1%)
["lp", "issue_83"] 1.10 (5%) :x: 1.00 (1%)
["scheduling", "all_different_except_0_len10"] 0.84 (5%) :white_check_mark: 1.01 (1%) :x:
["scheduling", "all_different_except_0_len12"] 0.93 (5%) :white_check_mark: 1.01 (1%) :x:
["scheduling", "furniture_moving"] 0.88 (5%) :white_check_mark: 1.01 (1%)
["sudoku", "top95_1"] 0.90 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_11"] 0.93 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_16"] 0.91 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_21"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_26"] 0.89 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_31"] 0.93 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_41"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_46"] 0.89 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_51"] 0.90 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_56"] 0.91 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_6"] 0.93 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_61"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_66"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_71"] 0.90 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_76"] 0.92 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_86"] 0.93 (5%) :white_check_mark: 1.00 (1%)
["sudoku", "top95_91"] 0.90 (5%) :white_check_mark: 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

Julia versioninfo

Target

Julia Version 1.5.3
Commit 788b2c77c1 (2020-11-09 13:37 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  uname: Linux 5.10.13-arch1-2 #1 SMP PREEMPT Sat, 06 Feb 2021 11:07:29 +0000 x86_64 unknown
  CPU: AMD Ryzen 7 PRO 4750U with Radeon Graphics: 
                 speed         user         nice          sys         idle          irq
       #1-16  1776 MHz    1166063 s    1175911 s     508056 s   20776455 s          0 s

  Memory: 38.482669830322266 GB (540.52734375 MB free)
  Uptime: 61967.0 sec
  Load Avg:  4.6494140625  4.4033203125  3.6171875
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, znver2)

Baseline

Julia Version 1.5.3
Commit 788b2c77c1 (2020-11-09 13:37 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  uname: Linux 5.10.13-arch1-2 #1 SMP PREEMPT Sat, 06 Feb 2021 11:07:29 +0000 x86_64 unknown
  CPU: AMD Ryzen 7 PRO 4750U with Radeon Graphics: 
                 speed         user         nice          sys         idle          irq
       #1-16  1492 MHz    1371237 s    1191090 s     546527 s   21948889 s          0 s

  Memory: 38.482669830322266 GB (573.453125 MB free)
  Uptime: 62872.0 sec
  Load Avg:  2.03271484375  3.09716796875  3.6298828125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-9.0.1 (ORCJIT, znver2)