search

Wikunia / ConstraintSolver.jl

ConstraintSolver in Julia: Blog posts ->
https://opensourc.es/blog/constraint-solver-1
MIT License
136 stars 14 forks source link

wording improvement, style #55

Closed matbesancon closed 4 years ago

matbesancon commented 4 years ago

Nothing major here. init() was troubling because it looks like the init function of the module, which is creating side effects on it. It comes more from an OOP world, you just need to declare a constructor here, since it is what this function is doing. In case you want to keep init for a while, I added a deprecation macro, so CS.init() is still available

Wikunia commented 4 years ago

Ah yeah that makes sense. Thanks for the contribution. Will have a deeper look on Sunday evening/Monday.

matbesancon commented 4 years ago

Yes don't merge it just yet it still seems to be failing somewhere

On Sat, Jan 11, 2020 at 2:42 PM Ole Kröger notifications@github.com wrote:

Ah yeah that makes sense. Thanks for the contribution. Will have a deeper look on Sunday evening/Monday.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Wikunia/ConstraintSolver.jl/pull/55?email_source=notifications&email_token=AB2FDMV4ML2YNGZG23OVZATQ5HEC7A5CNFSM4KFSA7NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWCHCA#issuecomment-573318024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2FDMVET6ZWKKOSMLN2633Q5HEC7ANCNFSM4KFSA7NA .

-- Mathieu Besançon

matbesancon commented 4 years ago

good to merge now