Wikunia / brackets-FuncDocr

FuncDocr generates JS/PHPDoc annotations for your functions
101 stars 14 forks source link

Preferences for FuncDocr always showing #51

Closed IamAdamJowett closed 9 years ago

IamAdamJowett commented 9 years ago

Love the extension except the Preferences modal is showing each and every time I start up brackets which is starting to get a little annoying. It seems to save the preferences to the preference file ok, so not sure why it shows on startup each time.

image

IamAdamJowett commented 9 years ago

Ok after looking through the code, I can see it is showing due to there being a conflict with the keyboard shortcut with another extension (Grunt for Brackets) which also tries to use Ctrl-Alt-D. Makes sense to show it, but perhaps it needs specific modal messaging to let the user know why it is showing in this case.

Wikunia commented 9 years ago

Ah okay and thanks for the idea!

Wikunia commented 9 years ago

brackets-funcdocr-menu-reminder 51 I am so sorry! I've kind of forgotten this issue. Do you thing this message would be okay? I know it isn't the best (I am definitely not a designer :D) but I hope it's "okay" ;) Have a nice weekend @IamAdamJowett

IamAdamJowett commented 9 years ago

All good @Wikunia thanks for all the work. A simple "This shortcut is already in use, please choose another" will do the trick for sure.