search

Wil-Huffman / mod_0_assessment

0 stars 0 forks source link

Technical Assessment - Results #1

Open ericweissman opened 3 years ago

ericweissman commented 3 years ago

Great work on the assessment! You did a much better job of writing clear, concise commit messages that follow standard conventions.

For the program specific challenge everything looks good in terms of creating correct variables. The only piece I recommend you continue to experiment with is figuring out how to remove an element from an array. This could be a good exercise to do more research and experiment on repl.it to see if you can accomplish the task.

The objects you created did a great job of naming for your keys and you used proper syntax throughout. I would like you to double-check you spacing in modelA vs. modelB - there is some inconsistency there that ideally would be the same for both objects (I prefer your approach in modelB).

Once you make that change you are technical ready and will be ready for Mod 1 assuming your M1 Prework is solid and complete!

Wil-Huffman commented 3 years ago

Changes made on modela.js, and variables.js per feedback.

On Sun, May 23, 2021 at 9:15 AM Eric Weissman @.***> wrote:

Great work on the assessment! You did a much better job of writing clear, concise commit messages that follow standard conventions.

For the program specific challenge everything looks good in terms of creating correct variables. The only piece I recommend you continue to experiment with is figuring out how to remove an element from an array. This could be a good exercise to do more research and experiment on repl.it to see if you can accomplish the task.

The objects you created did a great job of naming for your keys and you used proper syntax throughout. I would like you to double-check you spacing in modelA vs. modelB - there is some inconsistency there that ideally would be the same for both objects (I prefer your approach in modelB).

Once you make that change you are technical ready and will be ready for Mod 1 assuming your M1 Prework is solid and complete!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Wil-Huffman/mod_0_assessment/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATEOYJYJA26DI5QFTPB64BLTPEEXJANCNFSM45LYBEZQ .

-- Wil Huffman e: @. @.>io c: 773.653.7730