search

WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.
Apache License 2.0
33 stars 15 forks source link

No description field appears when a user selects "Other" for Activity, Fishery, Gear, or Catch #285

Closed MikeyDubs closed 2 years ago

MikeyDubs commented 4 years ago

Description fields should appear after a user selects "Other" from ANY drop down menu, not just EMS. This includes Activity, Fishery, Gear, and Catch. Currently, this doesn't happen with Activity, Fishery, Gear, and Catch.

The description field should be free-form text the user inputs.

Issue - Activity, Catch, Gear: IMG_8348

Issue: Catch IMG_8349

Should be - Activity, Fishery, Gear: Summary Copy

Summary Copy1

Should be - Catch: Amount Copy

Look to how EMS is implemented and do the same for Activity, Fishery, Gear and Catch. Note that what should be stored in the database is the description when "Other" is selected. e.g. if Activity is "Other" and the description is "Sailing", then "Sailing" should be stored in the activity field in the database.

am-MongoDB commented 4 years ago

Note that will require changes in the views, view models and models.

The model changes are dependent on https://github.com/WildAid/o-fish-realm/issues/135 being implemented

Sheeri commented 4 years ago

No change needed to the viewModel - The ideal is to have the "other" value just save in the field, as if it was a menu item. so, if menu item is 'Other' (or a translation thereof) then save the 'Description' field to the actual field (e.g. Activity=Other, description='Sailing', save 'Sailing' to Activity in the database).