WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.
Apache License 2.0
33 stars 15 forks source link

logging out with draft boardings #290

Closed o-fish-wildaid closed 4 years ago

o-fish-wildaid commented 4 years ago

If a user clicks 'Log Out' while they have draft boardings a modal should appear warning that drafts will be deleted - as per the design at https://mongodb.invisionapp.com/share/M6YN2Y77B8E#/screens/430515895_Modal-Logout

am-MongoDB commented 4 years ago

@Sheeri This modal isn't needed because draft reports are persisted in Realm

am-MongoDB commented 4 years ago

The exception would be if we wanted to intentionally delete the draft reports when logging out

am-MongoDB commented 4 years ago

It turns out that we do want to explicitly delete the draft reports when the user logs out.

am-MongoDB commented 4 years ago

This should use the cascading delete function being added under https://github.com/WildAid/o-fish-ios/issues/300

Sheeri commented 4 years ago

The customer has requested that drafts be able to be saved across mobile to web - that is, a SAVED draft boardings that hasn't been submitted, should NOT be deleted.

I apologize for the change in functionality; this reverses what we were told earlier.

am-MongoDB commented 4 years ago

@Sheeri does the mobile user still have the option to explicitly delete a draft report?

Sheeri commented 4 years ago

Yes, they can still opt to delete a draft report.

On Mon, Sep 21, 2020 at 4:59 PM Andrew Morgan notifications@github.com wrote:

@Sheeri https://github.com/Sheeri does the mobile user still have the option to explicitly delete a draft report?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/WildAid/o-fish-ios/issues/290#issuecomment-696373116, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANPQ2HVZXJDB7C5366POF3SG65EXANCNFSM4RQSFKRA .

--

{ name : "Sheeri Cabral", title : "Product Manager", pronouns : "she/her", phone : "857-205-9786", location : "Boston, MA USA" }

am-MongoDB commented 4 years ago

@Sheeri – so I guess that this issue can be closed?

Sheeri commented 4 years ago

Indeed! Closing.