WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.
Apache License 2.0
33 stars 15 forks source link

Make permit number appear in all caps on vessel information page #337

Closed nugmanoff closed 4 years ago

nugmanoff commented 4 years ago

Closes #245

This one is also is a part of Hacktoberfest 2020 :)

Sheeri commented 4 years ago

Hi @nugmanoff - I see you've submitted another PR - we love to see it! Our team will review this before this time on Monday (3 business days).

Thanks so much for your contributions!

Sheeri commented 4 years ago

Hi @nugmanoff it also seems like this pull request had a few extra commits dragged along with it. Can you get rid of the extraneous commits on this PR too? Thanks!

nugmanoff commented 4 years ago

@Sheeri I tried to get rid of them but no luck so far. I can't really understand why it even occurred, can you give me some directions on how to fix it?

Sheeri commented 4 years ago

What I've done in the past is:

go into a new directory and clone there, let's say I'm in ~sheeri/github/o-fish-ios I will cd ../ to get to ~sheeri/github Then clone into a new directory:

git clone https://github.com/WildAid/o-fish-ios.git o-fish-ios-clean

Then look at the files I know I changed, and resubmit only those changes (by copying the files, or by making the changes again).

Sheeri commented 4 years ago

Looks like you figured it out while I was typing an answer! 👍

Sheeri commented 4 years ago

@nugmanoff Just one more - the README file...you're so close!

nugmanoff commented 4 years ago

@Sheeri this one got messed up & accidentally closed ;( I opened a new one #343, so sorry for bloating the repo