WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.
Apache License 2.0
33 stars 15 forks source link

Draft Boardings navigation bar show fix #359

Closed pankova closed 4 years ago

pankova commented 4 years ago

Related Issue

Fixes #331

Checklist:

Optional items:

o-fish-wildaid commented 4 years ago

Review PRs

am-MongoDB commented 4 years ago

@pankova @Sheeri what versions of Xcode/iOS was the issue observed on – I've not been able to reproduce it.

pankova commented 4 years ago

@pankova @Sheeri what versions of Xcode/iOS was the issue observed on – I've not been able to reproduce it.

Xcode 11.6. iOS 13.6. I haven't installed XCode 12 because of my work project. But If there is no bug on last XCode it's good news 🙂

Sheeri commented 4 years ago

OK, so if we don't need the code, we can just close this, right? (we won't mark it invalid, so you will still get hacktoberfest credit).

pankova commented 4 years ago

OK, so if we don't need the code, we can just close this, right? (we won't mark it invalid, so you will still get hacktoberfest credit).

OK, if the problem will appear, we know at least one way to fix it. And I will remember this SwiftUI+XCode latest version tip 🙈 Thanks!

Sheeri commented 4 years ago

Hi @pankova! We noticed you haven't claimed your digital MongoDB swag - you're still eligible even though we didn't merge this pull request. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.