Script to Scan Source and Update Localization Files

WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.

Apache License 2.0

33 stars 15 forks source link

Script to Scan Source and Update Localization Files #369

Closed bladebunny closed 4 years ago

bladebunny commented 4 years ago

Related Issue

Fixes #339

Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[x] I have commented on the linked issue
[ ] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

[ ] My change adds new text and requires a change to translations.
[x] My change requires a change to the documentation.
[ ] I have submitted a PR to the documentation repo.
[ ] I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
[ ] This change depends O-FISH Realm repository changes (explain below)
[ ] This change depends O-FISH Web repository changes (explain below)
Optional: Add any explanations here Added REAME to Scripts directory with instructions and description.
Optional: Add any relevant screenshots here

bladebunny commented 4 years ago

You should be able run on it just the project source files. They'll be in .../o-fish-ios/o-fish-ios. Two layers in, the outer layer will obviously give you many more hits. But we could also add a 'skip' list if you find other paths are being included that shouldn't be.

bladebunny commented 4 years ago

BTW - yes will make the requested updates later this evening.

bladebunny commented 4 years ago

@Sheeri: I made updates based on the review feedback. Thank you. I did not add an ignore or blacklist for now. You should be able to prevent inclusion of Pods directories by just running against o-fish-ios/o-fish-ios (which is at a lower dir level than Pods) ... but I can add ignore lists if its really needed.

Sheeri commented 4 years ago

@bladebunny my sincere apologies, I completely missed your update! Will check this right now.

Sheeri commented 4 years ago

Hi! I'm still getting "R%@ C%@" = "R%@ C%@"; as a change. But this has waited long enough, and I'm happy with it as-is. I'll add another issue to add a skip list to the script - can we make that be a file in the scripts directory please? that way we can have a list that stays with the code.....(it can be on by default, and people should be able to specify a different file, or no skip list).

e.g.

--skip-list=/path/to/file - by default, "skip_list.txt" in the current directory --skip-list=false - don't use a skip list.

Sheeri commented 4 years ago

Congratulations! 🎉 🙌 🎆 ㊗️

This PR is great and has been merged into the code. Thanks so much for contributing! If you'd like, you can request to work on another issue. We really appreciate your effort!

To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.