search

WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.
Apache License 2.0
33 stars 15 forks source link

Dark mode: Boarding summary pre-search #379

Closed Sheeri closed 2 years ago

Sheeri commented 4 years ago

When the user clicks "Find Records" or "Board Vessel" on the home page, they get to the "find records" page where the 5 most recent vessels boarded appear. Then they click on a vessel, and see the vessel profile page. From there, they can select a previous boarding to see a summary. This page is not rendering properly in dark mode.

Is your feature request related to a problem? Please describe. In dark mode, this page should look like this: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591784_Boarding_Record

There was a lot of setup in https://github.com/WildAid/o-fish-ios/pull/361/files and the fix for this issue should be in the same style and reuse code where possible.

Color key for light mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591768_Color_Key_-_Light_Mode Color key for dark mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591769_Color_Key_-_Dark_Mode Component Color specs for light mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591770_Component_Colors_-_Light_Mode Component Color specs for dark mode: https://mongodb.invisionapp.com/share/PCYZ6ZW7FR8#/screens/433591771_Component_Colors_-_Dark_Mode

Dmitriy-Holovnia commented 2 years ago

The issues was fixed in https://github.com/WildAid/o-fish-ios/pull/427

Sheeri commented 2 years ago

Indeed, that has been fixed. Looks beautiful!