Fix scroll view on basic information page

WildAid / o-fish-ios

iOS app for the Officer's Fishery Information Sharing Hub (O-FISH). The mobile app allows fisheries officers to document and share critical information gathered during a routine vessel inspection.

Apache License 2.0

33 stars 15 forks source link

Fix scroll view on basic information page #426

Closed Dmitriy-Holovnia closed 2 years ago

Dmitriy-Holovnia commented 2 years ago

Issue #88

Checklist:

[x] I have read the contributor's guide.
[x] I linked an issue in the previous section
[ ] I have commented on the linked issue
[x] I was assigned the linked issue (not required)
[x] I have tested the change to the best of my ability against the sandbox or a local build.

Dmitriy-Holovnia commented 2 years ago

Hi @Dmitriy-Holovnia can you give me a sense of how I can test what was fixed? I tested what's in issue #88 and I can see that the "password" field does come up on top of the keyboard, but the test case of adding an EMS on the Vessel page and clicking "Registry Number" still has the keyboard hiding the field.

Hi @Sheeri. Now you can scroll down to the password field when keyboard is appears.

Sheeri commented 2 years ago

@Dmitriy-Holovnia here is a screenshot of the problem - when I hit the plus at the bottom to add a 2nd EMS, the new fields come up, but there is no scrolling so you can’t see that more than one field has been added.

5ADE4352-18FB-4B11-A7DD-47A210C7849C

Sheeri commented 2 years ago

Once I click the + the scrolling should be so that we see both fields and the -Remove EMS, like this:

![Uploading 84569F5A-CD9A-40E1-A5C8-8F46E532D637.png…]()