WildAid / o-fish-web

Web application for the Officer's Fishery Information Sharing Hub (O-FISH). The web app allows agencies to gain insights from the aggregated information gathered during a routine vessel inspection (submitted via the web app).
Apache License 2.0
32 stars 41 forks source link

Add button to skip navigation #345

Closed CR96 closed 3 years ago

CR96 commented 4 years ago

Is your feature request related to a problem? Please describe. This button will allow easier access to the main page content when using a screen reader.

Describe the solution you'd like Add a "skip to main content" button.

Sheeri commented 4 years ago

Hi @CR96 Just to be clear - you mean a button in the top bar navigation, early on, so that a screen reader doesn't re-read the headings on every page, which would be repetitive and boring for people using a screen reader?

Are there examples of this sort of button out there? is it a 'hidden' button that is only visible to a screen reader?

CR96 commented 4 years ago

@Sheeri Exactly that. Generally they're hidden until they're focused, usually through CSS styling that positions the button offscreen. GitHub has one that appears when using tab navigation.

I implemented this on another project a few years back: https://github.com/Jasig/uPortal/pull/882

Sheeri commented 4 years ago

Perfect! then yes, this is a great issue to work on. Would you like to be assigned to it?

CR96 commented 4 years ago

@Sheeri I'll wait until after Hacktoberfest is over, then take this if nobody claims it. I have my pull requests so I'll give someone else a chance at a last-minute PR! :)

Sheeri commented 4 years ago

@CR96 That's awesome! I will come back around Monday if nobody has asked for it yet. I love that you are making sure everyone can be included!

Niaz-Ul-Haque commented 4 years ago

Can I get assigned to this? New opensource developer here, wants to learn experience through opensource. Thank you!

Sheeri commented 4 years ago

Hello @Niaz-Ul-Haque, thanks for offering to work on this! I have assigned it to you.

jflip commented 3 years ago

Mind if I give this a go, still getting used to the project 👍

Sheeri commented 3 years ago

Hello @jflip, thanks for offering to work on this! I have assigned it to you.