Risk Filter functionality

WildAid / o-fish-web

Web application for the Officer's Fishery Information Sharing Hub (O-FISH). The web app allows agencies to gain insights from the aggregated information gathered during a routine vessel inspection (submitted via the web app).

Apache License 2.0

31 stars 41 forks source link

Risk Filter functionality #523

Closed mmhuseynov closed 2 years ago

mmhuseynov commented 2 years ago

Related Issue

Fixes #504

Checklist:

[ ] I have read the contributor's guide.
[ ] I linked an issue in the previous section
[ ] I have commented on the linked issue
[ ] I was assigned the linked issue (not required)
[ ] I have tested the change to the best of my ability against the sandbox or a local build.

Optional items:

[ ] My change adds new text and requires a change to translations.
[ ] My change requires a change to the documentation.
[ ] I have submitted a PR to the documentation repo.
[ ] I was not able to test... (explain below, e.g. you did not have permissions to test a specific feature)
[ ] This change depends O-FISH Realm repository changes (explain below)

Before

After

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

Sheeri commented 2 years ago

See this screen capture - If I filter for "green" and then add "red", both filters show as "red" and all the records are "red", even though the filter itself shows that "green" and "red" are both checked: https://user-images.githubusercontent.com/1767528/159028298-ffc62dfa-13a3-4a44-8cea-2fdd31e139e6.mov

In this scenario I expect one filter to show as "red" and one as "green", and I expect to see listings that are either green or red.

Sheeri commented 2 years ago

Hi @mmhuseynov - the filtering behavior works as expected, now there's just a little bit of a problem with the filter showing up more than once - here I have selected Amber and Red, and the filter shows 2 filters on amber and 2 filters on red. Can you fix that please?

Also, do you know why the map doesn't render properly when we use the filter?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
0.0% Duplication

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication