Search results page should redirect to vessel and crew for those listings

WildAid / o-fish-web

Web application for the Officer's Fishery Information Sharing Hub (O-FISH). The web app allows agencies to gain insights from the aggregated information gathered during a routine vessel inspection (submitted via the web app).

Apache License 2.0

31 stars 41 forks source link

Search results page should redirect to vessel and crew for those listings #63

Closed Sheeri closed 3 years ago

Sheeri commented 4 years ago

Like issue #28, on the search results page, vessel and crew listings should be clickable and redirect to those pages.

lenmorld commented 3 years ago

Hi I'd like to try this one

Sheeri commented 3 years ago

Hello @lenmorld, thanks for offering to work on this! I have assigned it to you.

Sheeri commented 3 years ago

@lenmorld do you still want to work on this one? To replicate:

Login
Use the search bar at the top to search for something
On the results part that pops up, click the bottom link that says "See all results for SEARCH_STRING"
From there, clicking on the boarding, vessel, or crew that shows up should go to the boarding or vessel or crew page.

Currently it looks like the boarding link is clickable but doesn't actually bring up a record, and nothing happens if you click on vessel or crew.

I'm sure it will be very similar to the work in https://github.com/WildAid/o-fish-web/pull/327 so it shouldn't be too hard...

lenmorld commented 3 years ago

Hi @Sheeri

I did a hard reset on my branch, that's why it got closed. I'm currently looking at it, ~~but also blocked by the data not loading https://developer.mongodb.com/community/forums/t/typeerror-agency-inboundpartneragencies-is-undefined/10822~~

Got that issue resolved by creating another user. I'm back on track now :) I'll have a PR by today or tomorrow