search

WildBamaBoy / minecraft-comes-alive

Replaces Minecraft's villagers with humans, who can be interacted with.
GNU General Public License v3.0
152 stars 179 forks source link

Incompatibility with Werewolves #1414

Open Cheaterpaul opened 5 months ago

Cheaterpaul commented 5 months ago

Minecraft Information (please complete all questions entirely):

Describe the bug

There is a conflict between Werewolves and MCA Reborn targeting the player renderer. Werewolves renders a werewolf model when the player transforms into a werewolf form. We explored a few ways how this can be best implemented, but every time we encountered the issues that the MCA Reborn villager feature (mixin) completely denies rendering of other models for the player.

Reproduction

  1. become werewolf /vampirism level werewolves:werewolf 14
  2. open skill menu
    • press p (default keybinding)
    • select fang button
  3. unlock beast form skill or survivalist form skill image
  4. exit menus
  5. Select form with mouse and click (best to use at day time) image

Solution 1

I found the option to disable the villager feature https://github.com/TeamLapen/Werewolves/issues/182, which will allow the werewolf model to be rendered again. It would be great if werewolves could be included in the default list

Solution 2 (not tested)

Only relevant if this mixin is intended to target only players.

Currently this will cancel all renderer regardless where they come from. An additional check for this instanceof PlayerEntityRenderer would ensure that only the default player rendering is disabled and not other renderer as well.

Remarks

the Werewolves 2.0.0.0-beta.3 was an attempt to extend PlayerRenderer in the werewolf player renderer, but is just causes more issues because MCA modifies the renderer to use PlayerEntityExtendedModels