WildMeOrg / Wildbook

Wild Me's first product, Wildbook supports researchers by allowing collaboration across the globe and automation of photo ID matching
https://www.wildme.org/wildbook.html
GNU General Public License v2.0
106 stars 68 forks source link

GPS coordinates not validated in bulk import #751

Open goddesswarship opened 1 month ago

goddesswarship commented 1 month ago

Expected behavior If encounters are missing data under a field, the bulk import review page (/import/standard-upload) should flag those cells in blue.

Current behavior If encounters are missing data under Encounter.decimalLatitude and Encounter.decimalLongitude fields, they are converted from blank cells to 0.0 and displayed in green.

Testing notes The result is the same if the lat/long field cells are changed from Numbers to General or Text. Spreadsheets for testing are in the services inbox with the same subject as the Community post.

Community link https://community.wildme.org/t/strange-bulk-import-error-messaging/3220

TanyaStere42 commented 1 month ago

If this only happens when species info is missing, then the error is correct, but the highlighting isn't. You can't bulk submit without species on Wildbook

goddesswarship commented 1 month ago

Right. It's the inconsistent flagging the lat/long fields between the two use cases that was initially raised. When species is missing it also throws in a "by the way, double-check these other fields, too." But if it's just some lat/long entries missing, it's not flagged at all. This could potentially be rolled into this other issue on bulk import not validating all fields https://github.com/WildMeOrg/Wildbook/issues/317. Let me know what you think.

TanyaStere42 commented 1 month ago

Gotcha. I think it makes sense as a separate ticket, but we should get rid of the info about the error. That behavior is as expected, and it seems like that's the problem with it in the unexpected behavior section

goddesswarship commented 1 month ago

Thank you! I updated the description for clarity.