WildMeOrg / Wildbook

Wild Me's first product, Wildbook supports researchers by allowing collaboration across the globe and automation of photo ID matching
https://www.wildme.org/wildbook.html
GNU General Public License v2.0
106 stars 72 forks source link

Can't search by photographer name when photographer email isn't present in encounter search in 10.4 #881

Open goddesswarship opened 1 week ago

goddesswarship commented 1 week ago

Expected behavior When performing an encounter search (/react/encounter-search) by photographer name, search results display encounters that match the search query.

Current behavior An encounter search by photographer name when there is no associated photographer email address on the encounter produces 0 results.

Testing notes Example encounter with photographer name but no photographer email address (does not appear in search with partial name or with exact match)

Example encounter with a photographer name and email address (search results appear with partial name, exact name, and email address)

Couldn't find an example in Seadragon to test with as all examples found have photographer name/email address combo.

Additional user notes

Sometimes information is under "Photographing User" and sometimes under "Other Photographers". Sometimes e-mail is visible, sometimes not. Sometimes there is nothing, like here: https://seals.wildme.org/encounters/encounter.jsp?number=28796997-f0c5-4a7e-8848-28adbbdc9b5b where "photographer name" should be "UEF" as all our research game cameras.

I did some test submissions:

  1. When the photographer name and e-mail is a Wildbook user, it goes under Photographing User, as it should. (https://seals.wildme.org/encounters/encounter.jsp?number=55cf48eb-980a-4e90-96ec-64362e1f2db6)
  2. When I ONLY put a photographer name, as "UEF" or "Tapani Nisula" without any e-mail address, no name is visible anywhere. (https://seals.wildme.org/encounters/encounter.jsp?number=cbb828c2-baaf-4d99-aab5-e81665ed22bf ), (https://seals.wildme.org/encounters/encounter.jsp?number=d1050eae-8496-40d8-880a-6f71c6eccffc)
  3. When I put a photographer name and address and the photographer isn't a user in Wildbook, both information is showing under Photographing User again. (https://seals.wildme.org/encounters/encounter.jsp?number=cff40b0c-8483-4b8c-a2f6-67cb834b5dc8)

Also; There was an issue with photographer information when we moved to Codex in 2022. All information was first not there, but was brought there afterwards, seemingly successfully. But if that information is useful for this issue.

Community link https://community.wildme.org/t/seal-wildbook-encounter-search-metadata-photographer/4395

goddesswarship commented 3 days ago

@holmbergius asked me to check if this was resolved with the 10.4.1 upgrade. Verified it's still occurring.

naknomum commented 3 days ago

i think this may be a two-part problem, so it will need twice as much investigating! haha :sob:

  1. it appears that the search query (when using that field "Submitter, Photographer, or Email Address") sends this as a value to only match submitters
  2. even when forcing to match on photographers (manually) this does not appear to be doing partial matches (e.g. match when passed just a first or last name).

part (1) likely needs a more complex (multi-field) query sent.

part (2) might be complicated by the fact we are expecting this to match names as well as email addresses. if a user types in the last name "smith" we might expect "john smith" to match. and yet, we would (probably) not want it to match foo@example.com to match every @example.com email address. so that is a weirdly complex mapping we might need.

TanyaStere42 commented 3 days ago

I think we would want it to match every @example.com address. And when they go "woah, that's a lot", they can adjust their search. We can't predict their data needs, just make their results clear

naknomum commented 3 days ago

I think we would want it to match every @example.com address. And when they go "woah, that's a lot", they can adjust their search. We can't predict their data needs, just make their results clear

noted. this might(hopefully) make the mapping change a little easier, for part (2).

goddesswarship commented 3 days ago

I've definitely had times where I did just the email domain search to identify users of a specific organization.