WildMeOrg / scout

MIT License
6 stars 5 forks source link

Cannot create overlapping bounding box annotations #47

Closed TanyaStere42 closed 11 months ago

TanyaStere42 commented 1 year ago

Current Behavior In Annotation and Ground Truth tasks, all bounding boxes must occupy distinct space The 2nd bounding box cannot be drawn / completed if its 1st or 2nd point is within a previous bounding box OR touching the label text or any icons of a previous bounding box.

behavior should be managed at /api/controllers/annotations.js

Expected Behavior Annotations can overlap

QA Checklist

Verify that a second annotation is drawn when there is an overlap of area For annotation task:

For ground truth task:

simbamangu commented 1 year ago

This is a blocker - there are plenty of images where animals are close enough that the attempted 2nd box touches the first and can't be completed. The 'workaround' would be to do incomplete annotation.

simbamangu commented 1 year ago

Note that the label text box of the 1st box also blocks positioning of the 2nd box, not just the original bounding box.

TanyaStere42 commented 12 months ago

@simbamangu can you verify QA requirements? And let me know if there's any additional detail I need to add

simbamangu commented 12 months ago

Further description of overlap issue and suggested QA description:

The 2nd bounding box cannot be drawn / completed if its 1st or 2nd point is within a previous bounding box OR touching the label text or any icons of a previous bounding box.

QA: verify that a 2nd box can be completed when its start or end points intersect with any other bounding box, text or icons from previous drawing object.

TanyaStere42 commented 11 months ago

@simbamangu we're updating the requirements you suggested to no longer include "start on any point of canvas, other box, icon". Because there's event listeners, we either shut down all other functionality besides box-drawing, or we require annotations start in blank canvas space

TanyaStere42 commented 11 months ago

@simbamangu Product verified, ready for QA. Click the boxes on the checklist and leave a comment with any notes as you finish @erinz2020 Great job!

erinz2020 commented 11 months ago

@TanyaStere42 Thank you for verification.