search

WildMeOrg / scoutbot

The computer vision for Wild Me's Scout project
Apache License 2.0
5 stars 3 forks source link

Can pipeline(), pipeline_v3(), batch(), and batch_v3() be merged to remove redundancy? #15

Open vkirkl opened 3 weeks ago

vkirkl commented 3 weeks ago

The core work of scoutbot is done via four methods: pipeline(), pipeline_v3(), batch(), and batch_v3(), (see declarations in scoutbot/init.py). These look like they could well be reduced to as few as one method. Should we do a deeper code review and recommend a refactoring (or not)? Doing so may result in the removal of a lot of redundancy.

vkirkl commented 1 week ago

@LashaO ... would love your thoughts on this!

LashaO commented 1 week ago

Hey @vkirkl This is a valid as best practice and for usability. On high level the pipelines share a lot of similarity, and were developed independently. I think there is a high chance the non-v3 methods 'pipeline' and 'batch' might be dropped or conserved as they are part of legacy code for an method model that has been since surpassed. I do agree that is the way to go for future additions.