WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Show thread bug #104

Closed mike537 closed 11 years ago

mike537 commented 11 years ago

Just upgraded to the latest version 2.0 on both our test and main forums by uninstalling older version and then a clean install as suggested, all went well but came across a small problem with our custom boxes.

As with previous versions i have increased the width of left column in pixels from the default 160 to 200 so that it looks better on our forum. I have done this for all of the scripts but i have noticed that despite changing the width on the showthread page as the picture shows the boxes do not increase in width, all the rest have increased OK . This now causes the width of the side box to over flow into the threads and the width of the side boxes remain the default size. I have tried on both of our forums with the same issue.

For now i have disabled showing of these custom boxes in the show thread. But the issue seems to be that unlike anywhere else the pixel width of the side boxes will not increase on the show thread pages.

capture . capture1

WildcardSearch commented 11 years ago

I have been making some updates this week. Can you be sure you have the version that is uploaded now? We should have solved that problem (#97) already here: https://github.com/WildcardSearch/Advanced-Sidebox/commit/72ce90b7884154499e2c5dbecefcc3c32e3816f6

mike537 commented 11 years ago

Thanks wildcard i did have a look but missed that issue you mentioned, i have now downloaded the recent version and uploaded it and all is working as it should.

Sorry for any trouble caused.

mike537 commented 11 years ago

One thing i have found with the latest download Wildcard is that in the upload>inc>plugins folder there is 2 php files the new asb.php file and the old adv_sidebox.php file.

Once you have uploaded these and activated them it shows a warning in the Admin CP that there is still some old version files on the server that needs deleting. Took me a while to track it down but once i deleted the old adv_sidebox.php all was fine. Sure some others may find this out as well when they download the latest version and wonder what the warning means.

The download zip file i used was the latest master file.

WildcardSearch commented 11 years ago

Hehe that's already an issue too: #101

I included adv_sidebox.php to overwrite the 1 series plugin (if it exists) to keep two instances of ASB from appearing in ACP in the event that it was an upgrade. The problem is that even for fresh installs, the adv_sidebox.php file triggers the warning.

I will get it fixed, but FYI, all you have to do to get past the warning is click the link below the warning :wink:

mike537 commented 11 years ago

OK must look at issues in future, i did have a quick look just did not have the time to have a long look at them though or i guess i would of found it.

BTW i did try that link several times during the process on both of our forums but it did not work, still showed old files were there after. In the end i had to go into FTP to find the file and delete it that way.

WildcardSearch commented 11 years ago

Ah, I see. Well I'll give it a look when I am there.

Thanks for the reports and don't worry I am always relieved to find out we don't have another bug :smiley_cat: