WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Side Boxes Don't Upgrade With Their Parent Add-on Module #118

Closed WildcardSearch closed 10 years ago

WildcardSearch commented 10 years ago

When a module is detected by the core to have been upgraded (the file was written over by one with a higher version), ASB runs an upgrade method of the module's class to handle any additional templates/settings or changes in the old templates/settings.

However, if instances of the module (side boxes of that type) already exist, they are not currently updated unless the add-on module had no settings at all previously.

On module upgrade, we need to be updating the settings of any children that already exist. This will solve the problem without requiring any edits elsewhere in the code unless I am mistaken.