WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Missing strings in acp-configuration-settings #120

Closed avril-gh closed 10 years ago

avril-gh commented 10 years ago

After overwriting files from 2.0 to 2.0.1 it should auto update without need to use 'uninstall' / 'install' ? I dont know but i noticed this after update. asb_nl myBB 1.6.11 ACP language english Then i used 'uninstall' / 'install' and it appeared ok asb_nl2 Now im not sure it was just coincidence or... :ghost:

and... happy new year 2014 Wild !! :sparkles: :sparkles: :star: :sparkles: :star2:

WildcardSearch commented 10 years ago

Happy New Year @avril-gh

I don't know what is up with that. MyBB has confirmed a bug with their language support so idk if I should worry about this or not :smile:

avril-gh commented 10 years ago

I don't know what is up with that. (...)

Either me. I didnt expected such thing to happen and updated everything so fast, that i cant tell now why exacly it happened and what caused this. (was just total suprise)

(...) MyBB has confirmed a bug with their language support so idk if I should worry about this or not

I think you have allready alot of work sheduled, so lets not expand this queue with mystery puzzles, and close it for now. If it wasnt coincidence and there is really such problem it will eventualy come back anyway.

Happy New Year @avril-gh

ye yee ! :star: :star2: :star:

Destroy666x commented 10 years ago

As for the MyBB language bug, they were against fixing it because this is 'unintended behavior' (and there are several plugins doing this, Advanced Sidebox is most popular out of them, I think). So I'd fix it in plugin before next topics about it are created - just need to add language strings loaded in ACP to [lang]/admin.

WildcardSearch commented 10 years ago

Thanks for the input.

Why wouldn't they fix it if it is screwing up plugins?

avril-gh commented 10 years ago

(...) just need to add language strings loaded in ACP to [lang]/admin.

Thanks for sharing the info @Destroy666x

Destroy666x commented 10 years ago

Because, as I mentioned, they think it's unintended behavior and the plugin-side fix is just a matter of moving something. I don't understand why they rely on plugin authors though. Fixing it should be a lot easier for them.

However, even though they were negative (Here you can read more:http://community.mybb.com/thread-146406-post-1043518.html#pid1043518), they said they're 'working on solution', which will be possibly included in next releases (that's why I think getting rid of the bug yourself is a better idea, instead of waiting).

BTW, I wish you both (and the rest who's reading this comment) Happy New Year.

EDIT: Nvm, MyBB 1.6.12 released today fixed it, hopefully.

WildcardSearch commented 10 years ago

Great to hear.

The thing is, I have separate language files for both ACP and form side and have even gone so far as to duplicate the addon-module language file in both places . . . I just can't see how I could need to move anything.

Maybe I am missing something.