search

WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Title and Description for Maintain Aspect Ratio (Who's Online Setting) Missing #145

Closed Tanweth closed 10 years ago

Tanweth commented 10 years ago

The Maintain Aspect Ratio setting for the Who's Online plugin is selectable and appears to be fully functional, but the title and description aren't being displayed in my Admin CP for some reason. Here's a screenshot: http://kerfufflealliance.com/pictures/asb-wol-settings-1.jpg .

WildcardSearch commented 10 years ago

Thanks for the report. I'll take a look.

WildcardSearch commented 10 years ago

@Tanweth I can't seem to reproduce the problem. Can you try deleting the side box and recreating it?

Tanweth commented 10 years ago

I tried deleting the sidebox and recreating it. I also tried removing the module and reuploading from a fresh download from GitHub. I even tried deactivating, reuploading in full, and reactivating Advanced Sidebox. It's a puzzling issue. It's the only setting that has this issue (I've checked most of the other sidebox modules).

Below is a new screenshot that also has the code inspector view on the element open in my browser, if that helps. It shows that it is going through the motions of generating the elements for the label and description, but doesn't actually show any text, as if it is not obtaining the text from the language file when generating the setting:

http://kerfufflealliance.com/pictures/asb-wol-settings-2.jpg

I should also add, since it may be related, that I noticed that you closed an issue a month ago indicating that in 2.0.4 you fixed archaic formats of "online" and "plugin" (from "on-line" and "plug-in"). However, on my website the addon still appears as "Who's On-line" (same with the addon "On-line Staff"). Does this indicate a carryover from a previous version?

WildcardSearch commented 10 years ago

Does this indicate a carryover from a previous version?

I have no idea what the last thing would mean. Probably that I missed something somewhere :tongue:

Oh! It just hit me! Because I have removed the extra copy of asb_addon.lang.php from the admin directory from the package, you are still using the old version! I'm willing to bet that is the problem. To verify, simply check yourforum/inc/languages/[language]/[admin_dir]/asb_addon.lang.php and if it exists then delete it. If the problems are solved then I'll know how to handle it.

Looks like I just need to alter the upgrade script to make sure that file is removed if user's are migrating from 2.0-2.0.3 . . .

Tanweth commented 10 years ago

That indeed fixed it! The archaic formats are now replaced, and the maintain aspect ratio text is now visible.

WildcardSearch commented 10 years ago

Okay I'll leave this open and close it when I have updated the upgrade script to ensure that file's removal.

Thanks for your help to track this down. :smile: