search

WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

headers allready sent error #17

Closed avril-gh closed 11 years ago

avril-gh commented 11 years ago

We can discuss here issue reported on MyBB forums by Lexy

I posted request to Lexy to provide screenshots without blured address bar parameters. (noticed the screenshot two even while blured, had unusual long parameters list)

It can be everything, not necessarily plugin fault. Anyway, we need more info to trace it.

WildcardSearch commented 11 years ago

I am certainly unable to reproduce that error.

My hands are full atm with BIG update. When I am done with it I will commit.

avril-gh commented 11 years ago

Installed this theme on my testing forum and still no error... He just have something installed there which interfere :cactus:

My hands are full atm with BIG update. When I am done with it I will commit.

cant wait to see :star:

WildcardSearch commented 11 years ago

I think I have got it just need to do some testing on a live forum and then I will commit.

As to the issue at hand, OP on MyBB has over 40 plugins installed on his board. It is almost certainly one of those plugins that is interfering but how would I figure out which one without dissecting his entire forum? :confused:

avril-gh commented 11 years ago

Tried these 2 modules and still no error...

Well lets wait for 1.3.4 then, if you say so that it have BIG changes then maybe there is possibility that bug was wiped out while in process of rewriting.

WildcardSearch commented 11 years ago

Possibly . . . I finally got everything tested but a new bug popped up so there will be another smaller delay. :frowning:

What I have right now works like this:

Install/Uninstall/Deactivate are completely unchanged except that uninstall also removes version info from the cache.

Activate now gets the old version (if available) and requires an upgrade script and then sets the new version in the cache.

The upgrade script updates all settings, db tables, etc. and rebuilds all the sideboxes using the updated information. It saves custom boxes (that have been removed) as User-defined box types and places a warning that table headers are no longer necessary (but gives them wrap_content=false so that if they ignore the warning it won't mess display up so bad). Script also removes the outdated modules (pms, search, welcome) and converts existing sideboxes accordingly.

It does other stuff too, but you will see soon :tongue:

Also added the setting for latest_threads

WildcardSearch commented 11 years ago

waiting on confirmation from lexy to say if this one is closed or not :fearful:

WildcardSearch commented 11 years ago

@avril-gh I just found the error :smile:

Look at line 1365 (last line) in adv_sidebox/acp_functions.php on the last commit (there is a stray dash '-' at the end of that file and it causes an error to be displayed . . . how weird :tongue:

avril-gh commented 11 years ago

Look at line 1365

in his sreenshot, error was pointing at line 1366 I checked it, but there was just end of file so i though that 'something wrong with this error message' and went to look through includes. And there on 1366 was invisible LF which was sent as this 'something' ... facepalm.

good eye :+1: