WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Front end version should differ to "internal" one #197

Closed Sama34 closed 10 years ago

Sama34 commented 10 years ago

To quote myself:

But if, for example, I change everything but templates and settings (lets say, I fix a SQL vulnerability), how will administrators know if they are running the latest code?

Unlike your view of how versioning should work, I think the version of modules should be able to be bumped up if anything but templates and / or settings change.

See: Sama34/OUGC-Portal-Poll#1

WildcardSearch commented 10 years ago

I don't know how to explain it any differently.

ASB module's version number are not for semantic versioning to be delivered to the public-- it is an internal version number used for upgrades.

If a module has changes that don't included templates and settings (but are important) then bumping the version of the plugin is the correct move (if it integrates with a plugin)-- if it is a stand-alone module, then yes, increment the module version for clarity but it is not necessary otherwise.

WildcardSearch commented 10 years ago

Okay I've had a chance to check things out and I can see where this would be useful.

I'll add another module property, public_version for module authors to keep their users alerted to changes even when it doesn't affect ASB.

@Sama34 will that do what you want?

Sama34 commented 10 years ago

Sounds like it will, thanks :-)

WildcardSearch commented 10 years ago

No problem. At first I couldn't understand why it would be needed but now I get it.

I'll show the public_version in the modules page if it exists or version if not. Sound right?

Sama34 commented 10 years ago

Sounds fine to me @WildcardSearch.

WildcardSearch commented 10 years ago

Done.