WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Why Even Have Install/Uninstall For Each Module? #38

Closed WildcardSearch closed 11 years ago

WildcardSearch commented 11 years ago

The core already automatically handles install/removal(uninstalls first)/upgrade so why not just create a simpler system and just have any valid modules automatically be installed/upgraded upon detection.

I propose removing the Install/Uninstall option from the popup and just leaving the delete option.

WildcardSearch commented 11 years ago

I just went ahead with the idea because it can always be put back in fairly easily. The functionality hasn't been removed, only the user access (menu item and url association removed).

This is meant to simplify the interface.

avril-gh commented 11 years ago

Ouch... I think you got 'simplicity' word too serious. You have implemented many cool, innovative, easy to use, and usefull options. Dont exaggerate with removing 'everything that moves'.

WildcardSearch commented 11 years ago

Wow you are really hard to please . . .

Anyway, tell me a reason why it would benefit admin to be able to uninstall? If they don't want to use an add-on they may ignore it or can even delete it.

I am not removing everything that moves, just those things that I can't find a purpose for.

avril-gh commented 11 years ago

Wow you are really hard to please . . .

No. i was, and i am, continuously pleased by many things from you Beginning at your desires and hard work which you put into attempts to push your project to higher levels, and ending at your matured, kind and friendly personality.

About changes you made lately, Im shocked, positively surprised, confused, speechless, and looking with interest at your changes wondering where it will lead, believing and hoping, that wind will blow into your ship's sail, and make you drift more to where sun shine, than where deep and dark water are.

WildcardSearch commented 11 years ago

That was one of the most beautiful things I have read ever. No kidding.

So I am taking all o this too personal and you are just going your opinion? Sorry I guess I have to apologize to you because I have allowed myself to become too emotionally involved in this project-- and that is causing me read things wrong.

So you like what you see? :smile:

I have looked at the code for many hours and I think this is a good place to do prerelease testing and tentibely set some kind of release date.

Two things first:

If you don't plan to continue to support your work then I need to know so we can change the link to point to a URL that will actually give the user support. Please let me know your intentions.

Other than that I think we keep testing and try to let the changes stop here (not counting what is already i the table or bugs that pop up).

I'm ready to release this :smile:

avril-gh commented 11 years ago

That was one of the most beautiful things I have read ever

Im glad to hear it, Since it is not a secret that we have different point of views, point of view is only personal matter, and as you see it does not meant the same as disapprovement. Its rather adventage because when together, it gives larger field of view, which is unavailable to one person alone.

do prerelease testing and tentibely set some kind of release date.

If you say so, im glad to see your confidence.

Online staff module needs your final approval and any corrections you see that need to be made

What is on my site not really reflects current situation but its rather an effect of fact that lately i was uncertain on what is exacly your point and developing plans and thus what actions should i get to adjust myself to it. Skiping unnecessary explanations and going to the point, Facts speak better than words, so instead discussing it here, i will make ready online staff for current asb release and pull it to your feature when ready, then you will review it and accept or not, after which i will adjust my services to reflect decisions taken and whats follow it. In case of eventual rejection we may discuss here about what you are finding being inappropriate, and take further steps and decisions.

WildcardSearch commented 11 years ago

Sounds good.

My main point was that if you decide not to support the module then the link should direct users to the main ASB page (but I will still give you author credit regardless) so that users will be able to get support and also I am not too fond of that message which I find misleading and offensive. It is not my page nor is it my repo so I digress.

In fact, you brought up our different points of view and I agree that it helps broaden the spectrum of ideas, but perhaps it also creates confusion.

From now on I will make a hard and fast rule that any add-ons created by another developer will not be included as default. If that were the case in this situation your decision to support/deny support of your add-on module would not affect ASB's release dates or schedules.

And I might add that @euantor is changing the entire settings system for MyAlerts and you don't hear me complaining. I am simply asking tons of questions and trying to make sure I understand what I need to change for MentionMe to maintain compatibility.

This is the way of MyBB plugins. We are amateurs most of us and it shows from time-to-time in the under-developed ideas that we eventually decide need to mature.

I know in the beginning there was a lot of 'Thanks' and 'I love your curly brackets' and now it is all 'No, that isn't what I meant' and 'Oh noes my ideas aren't perfect' but we are making progress and a lot of it is due to your dedication to this project so thanks and I really love your curly brackets. :smile:

avril-gh commented 11 years ago

My main point was that (...)

Ok...

avril-gh commented 11 years ago

After long considerations while being under influence of recent events and your reminders, i have decided as follows, which i believe will find your understanding and are satisfactory to all sides, and its desires.

Im officialy closing development of Online Staff addon originally created and maintained by me. Im also closing all services related to this project along with its support which i will no more provide as you desire.

As a creator and rightful copyrights holder im revoking your rights to modify, copy and distribute, my Online Staff addon and its code or parts of its code in any form.

I am asking you to remove files related to Online Staff addon created by me from Advanced Sidebox project and its distributions with particular refference at file inc\plugins\adv_sidebox\modules\staff_online_box\adv_sidebox_module.php

I also inform you that im not only, not part of this project anymore but also i dont want to be associated with this project anymore. Therefore please respect my will and consider that i would not be pleased to see my name mentioned in context of this project, to which i am not related, and which do not contain my code.

(and have never contained because files released under code name 'staff online' along with asb 1.3.4 is not my code but are 'whos online' addon cloned by you for experimental purposes which was never intended to be released, however was leaked by mistake along with release of asb 1.3.4 due to rushing factor)

I want you to know that i was pleased to meet you and work with you. I believe you are wise, matured and friendly person, unfortunately we have very different points of views and it just cant be helped.

With respect. Regards

WildcardSearch commented 11 years ago

It shall be done upon the next commit.

Thanks for all your hard work and good luck in whatever you do. :smile: