search

WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Portal default "Replacing entire template?" setting #394

Open Sama34 opened 4 years ago

Sama34 commented 4 years ago

Hi. By default the portal script replaces the entire template. This has proven to be quite frustrating for those ignoring this.

I spent some time figuring this issue out since for some reason the overwrite doesn't include variables like {$multipage}.

Regards.

WildcardSearch commented 4 years ago

Thanks for your time, but I'm not sure what changes you are suggesting...

Sama34 commented 4 years ago

I would suggest two, in order of preferences: 1) Disable the Replacing entire template? for all scripts for default, or 2) Use the default template for the affected scripts.

In this case, the Replacement Content for the portal script doesn't match the default portal template, having some variables like {$multipage} missing. I would consider this a bug.

I understand it is meant to show that it doesn't need to be the same code than in the original template, but it was quite frustrating as a first time installer because there was not clear indication that ASB was replacing the template (even when I had already experienced this in early versions [irrc]). I spend some time figuring out the reason for {$multipage} not displaying.

WildcardSearch commented 4 years ago

Thank you!

I'll work on ensuring that my replacement template isn't missing anything.

As to how to warn the user, not sure on the best way to do that.

Sama34 commented 4 years ago

You could add some HTML comments for administrators to notice, but honestly I won't be sure myself.

Settyness commented 2 years ago

I typically have my custom {$welcomebox} template displayed on the portal, but came across this behavior when attempting to enable ASB on the portal. Is there a workaround for this? I was unable to find a template group or global template for this portal replacement template.