search

WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Hide/show messes up layout a bit #61

Closed Destroy666x closed 11 years ago

Destroy666x commented 11 years ago

Happens randomly after clicking both arrows. https://docs.google.com/file/d/0B6pgReiHWGdSa2FsLW00eFBDY0U/edit https://docs.google.com/file/d/0B6pgReiHWGdSM0R0Ry1rQzQwQ00/edit https://docs.google.com/file/d/0B6pgReiHWGdSVk1adjI5YmFJRkE/edit

WildcardSearch commented 11 years ago

This is exactly why I should've waited to add this feature.

Will look into it.

WildcardSearch commented 11 years ago

I think this bug is related to #81 will get an update for this today.

Destroy666x commented 11 years ago

Still not fixed when sidebar is on both sides and you click multiple times. I think it's rather CSS issue, will take a look later.

WildcardSearch commented 11 years ago

Thanks I really have looked at it but nothing I do seems to fix it universally. :sad:

avril-gh commented 11 years ago

There, its fix for broken layout.

Initially object have no display property set. After its hidden with arrow it receive display: none and its ok at this point, however when its shown again, display: none is replaced with something (in this case it was block) which is not exacly as it was before it was hidden, therefore it looks (and are) differently (broken) Fix is restoring it to exact same state as it was before it was hidden (it has no display property set before it was hidden)

WildcardSearch commented 11 years ago

Thanks to @avril-gh this is fixed on my end. Going to close this.

avril-gh commented 11 years ago

yey, yey :two_hearts: