WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

Random quote fade out/settings #65

Closed Destroy666x closed 11 years ago

Destroy666x commented 11 years ago

Didn't know if write in the old issue or create new - you forgot to fix 1 thing - when fade effect is set to ON, it doesn't respect the max chars value. I've set it to 50 to test, it shows at least 100.

Another issue: https://docs.google.com/file/d/0B6pgReiHWGdSM21IQzFjQXl0b2c/edit Fade out doesn't work with long words and high max chars value (for example 160 default), instead doing that effect it adds 203; near the end.

I also recommend moving the text setting under min chars setting so it is more clear.

WildcardSearch commented 11 years ago

If you read the label for the 'Fade' setting is says clearly that when set to 'on' that the remaining text will be faded out. The remaining text is the text after the limit.

Perhaps this is unclear, but if I chose to go with a hard limit then when would I begin to fade text out? Half way makes a little sense.

Thoughts?

About moving the setting, yes that makes a lot of sense. Thanks for all your hard work.

Destroy666x commented 11 years ago

Well, actually the setting in ACP shows me this:

Gradually Fade Out Text Over Max? YES to fade NO to clip (. . .)

Even if it would say about remaining, I think it's confusing and unclear that admins limit max chars and yet it doesn't limit max chars.

Why for example halfway makes little sense? Could you elaborate?

WildcardSearch commented 11 years ago

Look I am hearing you and even agree that if you are having trouble with the wording maybe others will. What I am asking you to describe to me is how you feel it should work.

For instance, give me an example of the settings you think the module needs, what they should be titled/how they should be described and how the module should use those settings and I promise you that I will give it the utmost consideration given your helpful attitude and attention to this project.

I am not always clear on how things should work, but I can probably make it happen if you can help me understand why it would be better and what needs to be done to make it better.

Why for example halfway makes little sense? Could you elaborate?

No I said:

Half way makes a little sense.

Meaning that is my suggestion off the top of my head if we are going with the hard limit then we should consider where to start fading. 2/3 of the way? 1/2?

Once I understand (and we can agree upon) expected behavior then I can experiment a little with the cut-off and fade-out points . . .

Also, you seem to be rather knowledgeable in CSS, is there a way to fade out the text opacity rather than shrinking the font.

That would be much better to me.

Destroy666x commented 11 years ago

Well, my main point was the max chars option and fade out option aren't compatible together. One says his own history, the other one his own too. So I think there are 3 options to solve that.

In my opinion the 1st solution would be the best. It respects the max chars setting all the time and if users want to get full post (as it is now) they can enter value '9999999' or something like that. I hope you understand me now.

I think the opacity is a good idea too. Maybe make setting to choose either font or opacity, both are interesting concepts. CSS would be like this:

style="opacity:' . $opacity_variable . '; filter:alpha(opacity=' . ($opacity_variable * 100) . ');"

opacity is for all major browsers and has values from 0 to 1, filter is for older IEs and has 100x bigger values. The lower value the higher opacity.

WildcardSearch commented 11 years ago

get rid of remainder and do the effect on the cut off instead

Sounds best to me.

I still see a need for the minimum as well though. We don't want blank side boxes. They make our user's forums look bad and they make ASB look bad as well.

they can enter value '9999999'

They can enter 0 to avoid the limit altogether currently.

Opacity

So we are on the same page, what I am suggesting is that we somehow begin fading the opacity of the text midway until it is gone. Is that something that can be done with CSS without splitting the quote into parts?

I will do some research but I just thought you might be able to save me some time.

Cheers

Destroy666x commented 11 years ago

I still see a need for the minimum as well though.

Well yeah, didn't mention deleting it. Or is it connected somehow to remainder?

Is that something that can be done with CSS without splitting the quote into parts?

Hmmm, didn't see anything like that. I think that's a job for JS or PHP. CSS is rather static, don't think it can detect the middle of text and then lower it step by step without help of any other language. Maybe just with additions like LESS, however not sure too.

WildcardSearch commented 11 years ago

I was thinking more like masking.

I'll do some research this afternoon and try to do something better. I am starting to agree with your original reaction that the shrinking font just looks weird.

WildcardSearch commented 11 years ago

I simply don't know how to make this work the way I imagine it. Don't look for a solution to this one any time soon unless I suddenly get better at JS or CSS :smile: