search

WildcardSearch / Advanced-Sidebox

A plugin for MyBB forums that displays custom boxes on various forum pages.
GNU General Public License v3.0
20 stars 10 forks source link

ACP drag&drop + layout #66

Closed Destroy666x closed 11 years ago

Destroy666x commented 11 years ago

I think it isn't supposed to look like that, is it? (great idea btw) https://docs.google.com/file/d/0B6pgReiHWGdSQk0zZ21RLThTYkU/edit

In Custom Boxes it's a bit wrong too. https://docs.google.com/file/d/0B6pgReiHWGdSREhVMzVjRXE1MTg/edit My resolution is 1024x768, you probably have higher - always recommend to test design in small and high resolution.

Drag and drop doesn't work for me at all. Other JS in ACP, like dragging permissions in forum, works fine.

WildcardSearch commented 11 years ago

As to the resolution issues: sorry I hadn't realized that would happen on lo-res and I'll take care of it.

Drag and Drop: Can you give me some browser info? Or possibly test in a couple of different browsers. I tried it in IE8 and FF16 and it is working.

Sorry will try to straighten this out.

Also are the links working (each module is supposed to fall back to a clickable 'add new box' link in case of drag and drop failure)??

Destroy666x commented 11 years ago

At the beginning tested it in Chrome 24.0.1312.57. Now also tried FF19 and IE7. In all 3 links work, the moving cursor appears but when I click on the boxes, hold and try to move - nothing happens.

Maybe it's because you tested it on another ACP theme (as I have seen on screenshots) and there is a conflict with the default one. Or something connected to this error shown in Firbug DOM "Error: "throw $continue" is deprecated, use "return" instead"

And wondering why you're saying sorry - you're surely the nicest developer in MyBB i met till now. Everyone can make mistakes.

WildcardSearch commented 11 years ago

The links are supposed to be complete removed (and replace with text) by the JS that is in the main output (acp_function.php adv_sidebox_main()) so if the links are still there then there is something wrong with the JS that removes the links and possibly something else.

I am using the SharePoint theme and am embarassed to say I haven't tested it on any other theme because SharePoint is my favorite :blush: will do ASAP.

And I say sorry because I honestly tried to make sure this was cross-browser (scriptaculous library claims to be so) and it seems that isn't the case :frowning:

S yeah, I will be working on this today and any new data you get would be greatly appreciated.

Destroy666x commented 11 years ago

Could be also problem on my side. Tried changing to sharepoint theme and this came out "Warning [2] Creating default object from empty value - Line: 349 - File: C:\xampp\htdocs\mybb\admin\index.php PHP 5.4.7 (WINNT)". Tried changing back to default, deactivating your plugin, reuploading admin files from clean mybb 1.6.9 (was clean anyways) - error still there. Any idea what that is? That's the line in my index.php file (actually the middle of the if condition):

    if(!empty($admin_options['cpstyle']) && file_exists(MYBB_ADMIN_DIR."/styles/{$admin_options['cpstyle']}/main.css"))
    {
        $page->style = $cp_style = $admin_options['cpstyle'];
    }
WildcardSearch commented 11 years ago

According to php.net that means that $page is somehow not defined (as an object) so you are generating a STRICT warning. I may be wrong though.

I honestly don't know why that would be happening.

I have my testing environment set to STRICT and ALL so I should see that and since I don't edit the core at all it can't be a problem with the plugin.

Can you try it on a live site?

I just got through installing Chrome for the first time and I am having no issues at all.

Would you be willing to try WampServer? I find that it is very stable and reliable as a testing platform.

Destroy666x commented 11 years ago

You're right, JS works like a charm on a live site. My bad.

Reinstalled MyBB on XAMPP and tried WAMP, didn't work too - exactly same result. Maybe I have corrupt MyBB 1.6.9 package or something on my disc.

WildcardSearch commented 11 years ago

You're right, JS works like a charm on a live site. My bad.

I'm just relieved. I was imagining that no one could drap and drop but me :weary:

It would seem to me that you are having issues with the way your browser is configured (since WAMP or XAMPP have nothing to do with the was Browser-side scripting is done). Perhaps go through your configuration and see if there are special settings for intranet connections.

Destroy666x commented 11 years ago

Uhhhh, seems like 10 minutes after testing it live on our forum our domain got suspended. I better won't touch anything in next hours with that much of luck...

It would seem to me that you are having issues with the way your browser is configured (since WAMP or XAMPP have nothing to do with the was Browser-side scripting is done). Perhaps go through your configuration and see if there are special settings for intranet connections.

It happens in all 3 browsers I mentioned above. So all are configured wrong? What kind of setting let's say in FF can affect it? Also didn't really understand the part in brackets.

Sorry for going off-topic.

WildcardSearch commented 11 years ago

Uhhhh, seems like 10 minutes after testing it live on our forum our domain got suspended. I better won't touch anything in next hours with that much of luck...

Suspended? For what reason?

It happens in all 3 browsers I mentioned above. So all are configured wrong?

I don't know. That doesn't sound likely. And the fact that you can do forum permissions drag and drop does suggest there still might be some issue.

All we can do is keep testing.

The part in brackets means that JavaScript has nothing to do with XAMPP or WAMP, they only process the server-side code. So that tells us that your issues are not with the server but with the access to the browser.

Destroy666x commented 11 years ago

Suspended? For what reason?

Seems there is MySQL issue inside the plugin. Our developer who keeps forum running (i have only partial access) says it got suspended because of too high load on MySQL server. He restarted the server few times and it kept stopping working after short time. Disabled plugin and works fine now. I had the plugin only activated with rand_quote box on all scripts so either it's the core or the quote box.

WildcardSearch commented 11 years ago

Seems there is MySQL issue inside the plugin.

Nothing has changed with the database routines since 1.3.4

I had the plugin only activated with rand_quote box on all scripts so either it's the core or the quote box.

Do you remember the settings for the random quote box?

Destroy666x commented 11 years ago

Default settings, didn't change anything just tested the drag&drop with this box, went off for 10 minutes and forum was offline. When I came today on forum after one of restarts, I saw a MySQL error but it disappeared when I refreshed and the site worked normally, so unfortunately didn't take screenshot... However it mentioned connecting to database so I don't think it's connected to plugin, just database server was still restarting or something.

There were also errors when installing the plugin for first time, but couldn't make screenshot of them as they appeared for not even 1 second and don't appear when reinstalling.

WildcardSearch commented 11 years ago

Okay I'll do some more testing and double-check all the install routines. Thank you for your thorough report.

WildcardSearch commented 11 years ago

I can find nothing wrong with the db code. Closing this for now.