ACP JS issues

[Destroy666x]

1) It was originally found by avril-gh I think (at least my memory tells me I've seen it reported by her here but it disappeared). Line 277 in acp_functions should be:

    $page->extra_header .=  "<script src=\"../jscripts/adv_sidebox_acp.js\" type=\"text/javascript\"></script>\n";

( fixes https://github.com/WildcardSearch/Advanced-Sidebox/issues/66 )

2) Line 261 - there is language="JavaScript" which is deprecated, should be type="text/javascript"

3) If there are for example 6 module settings, the last one can't be seen (beyond browser) and edited in the modal box. Maybe make the box have fixed height and overflow: scroll, be paginated (Settings, More Settins, More Settings, ...) or something else.

[WildcardSearch]

Getting bogged down by real life so I can't say when I can get to this but I will certainly get it done by 1.7.1

Thanks for the reports and hard work. :smile:

[WildcardSearch]

okay I wound up with

// custom JS
    $page->extra_header .=  "<script src=\"jscripts/adv_sidebox_acp.js\" type=\"text/javascript\"></script>\n";

because I will be moving the file adv_sidebox_acp.js from jscripts to admin_dir/jscripts

Also in 1.7.1 I will go ahead and move the CSS file from inc/plugins/adv_sidebox to admin_dir/styles

If you guys know of any other path issues let me know.

Thanks for your hard word.

[WildcardSearch]

Oh and I changed the deprecate language attribute you mentioned as well @Destroy666x

[WildcardSearch]

Gonna close this but if I missed anything we can reopen it.

Thanks for the reports again.