Sidebar missing from showthread.php?

Kretol commented 11 years ago

I performed the upgrade as recommended (exported custom boxes, deactivated plugin, uploaded and overwrote existing files, and reactivated) and now it seems the Sidebar is missing from showthread.php. It shows fine on every other page. Under manage scripts, the status is Active. Nothing really jumps out that seems out of the ordinary in the settings for that script, either. I'll keep looking around.

Kretol commented 11 years ago

As a note, I do have Google SEO activated. Just to try and rule out any potential conflicts, I tried disabling the URL portion of it. Same issue. I shall check the template next!

WildcardSearch commented 11 years ago

Are you using more than one theme? Can you give me the showthread template contents of your theme?

Sorry you are having troubles.

Kretol commented 11 years ago

I am only using one custom theme which is the default for everyone (though come to think of it, I believe the normal MyBB theme is available for people to use as well, still). My current showthread template is:

<html>
<head>
<title>{$thread['subject']}</title>
{$headerinclude}
<script type="text/javascript">
<!--
    var quickdelete_confirm = "{$lang->quickdelete_confirm}";
// -->
</script>
<script type="text/javascript" src="jscripts/thread.js?ver=1603"></script>
<script type="text/javascript" src="{$mybb->settings['bburl']}/jscripts/thankyoulike.js?ver=150"></script>
<script type="text/javascript">
<!--
    var tylEnabled = "{$mybb->settings['g33k_thankyoulike_enabled']}";
    var tylCollapsible = "{$mybb->settings['g33k_thankyoulike_collapsible']}";
    var tylUser = "{$mybb->user['uid']}";
-->
</script>
{$ajaxreloadpage['head']}</head>
<body>
    {$header}
    {$pollbox}
    <div class="float_left">
        {$multipage}{$mysupport_jumpto_bestanswer}{$mysupport_form}

    </div>
    <div class="float_right">
        {$newreply}
    </div>
    {$ratethread}
    <table border="0" cellspacing="{$theme['borderwidth']}" cellpadding="{$theme['tablespace']}" class="tborder" style="clear: both; border-bottom-width: 0;">
        <tr>
            <td class="thead" colspan="2">
                <div style="float: right;">
                    <span class="smalltext"><strong><a href="showthread.php?mode=threaded&amp;tid={$tid}&amp;pid={$pid}#pid{$pid}">{$lang->threaded}</a> | <a href="showthread.php?mode=linear&amp;tid={$tid}&amp;pid={$pid}#pid{$pid}">{$lang->linear}</a></strong></span>
                </div>
                <div>
                    <strong>{$thread['threadprefix']}{$thread['subject']}</strong>
                </div>
            </td>
        </tr>
        {$classic_header}
    </table>
    <div id="posts">
        {$posts}
    </div>
    <table border="0" cellspacing="{$theme['borderwidth']}" cellpadding="{$theme['tablespace']}" class="tborder" style="border-top-width: 0;">
        <tr>
            <td colspan="2" class="tfoot">
                {$search_thread}
                <div>
                    <strong>&laquo; <a href="{$next_oldest_link}">{$lang->next_oldest}</a> | <a href="{$next_newest_link}">{$lang->next_newest}</a> &raquo;</strong>
                </div>
            </td>
        </tr>
    </table>
    <div class="float_left">
        {$multipage}{$mysupport_jumpto_bestanswer}{$mysupport_form}
    </div>
    <div style="padding-top: 4px;" class="float_right">
        {$newreply}
    </div>
    <br style="clear: both;" />
    {$quickreply}
    {$threadexbox}
    {$similarthreads}
    <br />
    <div class="float_left">
        <ul class="thread_tools">
            <li class="printable"><a href="printthread.php?tid={$tid}">{$lang->view_printable}</a></li>
            <li class="sendthread"><a href="sendthread.php?tid={$tid}">{$lang->send_thread}</a></li>
            <li class="subscription_{$add_remove_subscription}"><a href="usercp2.php?action={$add_remove_subscription}subscription&amp;tid={$tid}&amp;my_post_key={$mybb->post_code}">{$add_remove_subscription_text}</a></li>
        </ul>
    </div>

    <div class="float_right" style="text-align: right;">
        {$moderationoptions}
        {$forumjump}
    </div>
    <br style="clear: both;" />
    {$usersbrowsing}
    {$footer}
</body>
</html>

Customizations include those done for the plugins ThankYou-Like and MySupport.

WildcardSearch commented 11 years ago

I don't know if it will solve your issue, but the header search data was wrong for Show Thread-- instead of {$header} it should be {$ratethread} . . .

Kretol commented 11 years ago

No luck for me, I'm afraid! I changed the header search text on Show Thread from {$header} to {$ratethread} as you changed, but no fix in my case. :( I also tried deactivating and reactivating the plugin as well.

WildcardSearch commented 11 years ago

Give that a try. There was a problem with the action value added just before the plugin hook in show thread.

Kretol commented 11 years ago

The sidebox is now visible! Success! However, it does not seem to read the setting for the width of the sidebox for that script. I have the width of the left box set to 190 (like I do with all the other scripts), but it's using a value of 120. To note, all the other scripts are reading the custom width value correctly - just showthread is being difficult.

WildcardSearch commented 11 years ago

Well, getting closer anyway hehe . . . Sorry I will keep looking. This was a big re-write and it may take a bit to get the kinks worked out.

Thanks for being patient with me!

Kretol commented 11 years ago

Thank you for your efforts in quashing the bugs! :)

WildcardSearch commented 11 years ago

Okay there were many issues that you oncovered with your reports, so again I thank you.

Try out this update as it has solved many of the problems.

Kretol commented 11 years ago

It seems like things are working splendidly now! Thank you again! :cake:

WildcardSearch commented 11 years ago

You're welcome. Thanks for being patient with me.

I have found a couple of other things about the AJAX refresh that will need to change. I'll create issues for them and get them today a little at a time. (gonna close this one for now)

WildcardSearch / Advanced-Sidebox

Sidebar missing from showthread.php? #97