WildcardSearch / MentionMe

A plugin for MyBB 1.8.x that allows Twitter-style tagging and integration with MyAlerts
GNU General Public License v3.0
21 stars 9 forks source link

Ability to mention the whole group of users? #164

Closed Eldenroot closed 7 years ago

Eldenroot commented 7 years ago

@WildcardSearch - just a question - is possible somehow (adding support) to mention the whole group of users? For example I wanna mention all of my moderators instead of writing all names separately. It seems to be really useful (you can check this feature here in GitHub). Anyway it would need a permission system and the way how to select which group to mention).

Just a idea, low priority (Quick edit support is the last thing which I miss in MentionMe plugin). Thank you for your feedback!

WildcardSearch commented 7 years ago

It really sounds like a great idea. Immediate concerns would be:

Other than that, I would think there would be need to be a setting added so that admin can select which groups can be mentioned, and which usergroups could mention other entire groups...

What are your thoughts?

Do you see any other contingencies that need to be addressed?

Eldenroot commented 7 years ago

I agree with you, it would need a lot of changes and additions, but it could have a lot of cons. Maybe in MentionMe v3.3 😄 I think you mentioned everything in your post above.

For me, I am looking forward to Quick edit support, after that it will be perfect 👍 thank you for your great support and plugin!

WildcardSearch commented 7 years ago

You are certainly very welcome. Lets agree to table this for now and we can revisit once 3.2 is out and any bugs that spring up have been squashed.

WildcardSearch commented 7 years ago

Let me just put this here while it is on my mind.

RE: Permissions - In the past (ASB), I have learned that administrators will always want more control over permissions. So to me that means that having two settings:

Groups That Can Be Mentioned (leave blank for all)

and

Groups That Can Mention (leave blank for all)

...would probably not make everyone happy. I foresee requests of being able to prevent a specific group from mentioned another specific group. Since MyBB has no sort of user-to-user or group-to-group permissions, we would be effectively inventing that system from scratch. Something to think about...

Also, the ignore list. If you have ten moderators in the group and you mention the group, then that is ten queries to retrieve ignore lists for each user being mentioned, ten queries to alert each of those users, and that isn't even counting users which had to be queried (for display/group info) because they weren't active users before the mention...

Lastly, the early conclusion is that MentionMe may need to get an ACP page to handle this (ie. ASB's Manage Sidebox page). Then we could allow admin to control (or disable) group mentioning per group-- AND that would open the door for more precise controls like x user cannot mention anyone (abuse), x user cannot mention y group (hidden group), etc.

@Eldenroot thoughts?

Eldenroot commented 7 years ago

My idea, have a "simple" settings for (as you wrote above):

Lastly, the early conclusion is that MentionMe may need to get an ACP page to handle this (ie. ASB's Manage Sidebox page). Then we could allow admin to control (or disable) group mentioning per group-- AND that would open the door for more precise controls like x user cannot mention anyone (abuse), x user cannot mention y group (hidden group), etc.

Yes, that would be better way but it could be really complicated (anyway it would offer really good way how to set everything for admin's needs). I would start with a simple permission system and then extend it. It would probably bring some bugs which can be ironed out before moving to the advance system.

Also, the ignore list. If you have ten moderators in the group and you mention the group, then that is ten queries to retrieve ignore lists for each user being mentioned, ten queries to alert each of those users, and that isn't even counting users which had to be queried (for display/group info) because they weren't active users before the mention...

IIRC MyAlerts doesn't support sending multiple alerts at once, which would be really welcomed for that feature... any output @euantorano ? 😈

I will think about that and write more if anything... :)

WildcardSearch commented 7 years ago

My biggest concern after a day or so to think about it is performance. I feel like I just need to keep thinking about this until I see a way to make it perform well and then worry about the implementation.

We have to keep in mind that my track record of having free time has not been very consistent. Once I create more complexity then I will have to maintain it forever...

WildcardSearch commented 7 years ago

There more I think about this, the more I am leaning toward the thought that this belongs in MyAlerts... @euantorano?

euantorano commented 7 years ago

That's probably the best place to do it, yes. I'd need to think about the best way of doing it though.

WildcardSearch commented 7 years ago

Yeah it is complex, even in theory.

@Eldenroot It makes more sense to wait for MyAlerts to support group alerts before going ahead with this. Thoughts?

Eldenroot commented 7 years ago

@WildcardSearch - Agree! I will be looking forward @euantorano :)