search

WildcardSearch / MentionMe

A plugin for MyBB 1.8.x that allows Twitter-style tagging and integration with MyAlerts
GNU General Public License v3.0
21 stars 9 forks source link

Settings for "Open Mentions In a New Window/Tab?" doesn't work #210

Closed SvePu closed 6 years ago

SvePu commented 6 years ago

As wrote above the settings for the new tab option doesn't work.

Eldenroot commented 6 years ago

@SvePu - it is working for me without any issues, what version and browser do you use?

WildcardSearch commented 6 years ago

Hi @SvePu sorry so slow to reply.

To check if it is working, look at the page source for the mention and ensure that target"_blank" is being added to the link. If the target has been added correctly and yet the behavior is not what you expect, then the issue is how your browser treats the target tag in relation to link routing.

WildcardSearch commented 6 years ago

Confirmed as an issue with checking the wrong setting. Thanks for the help, @SvePu

Eldenroot commented 6 years ago

@WildcardSearch - I am not sure about this, because all mentioned usernames are automatically opened in a new tab... I use this since your release when you added this feature. However maybe it is a browser setting here and this is really bugged. Anyway thank you @SvePu!

WildcardSearch commented 6 years ago

Yeah, @Eldenroot, it is a confirmed bug. I referenced mention_format_names setting instead of mention_open_link_in_new_window in the code.

Eldenroot commented 6 years ago

Yes, I understand that but I am just confused that it is fine for me on my side :) thats just my 2 cents ;)

WildcardSearch commented 6 years ago

If you remember, there was some concern about the way it worked before. Perhaps your browser (or the browser settings) is causing different behavior? I don't know, for sure, but I am certainly checking the value of the wrong setting in the code :tongue: