doingnz
commented
1 year ago You can increase the speed of the method to populate the dummy list by only calling GC.GetTotalMemory(true) once by putting the call outside the for loop, or not calling it.
private List<TemperatureTable> DummyList(int rows)
{
long totalMemory = GC.GetTotalMemory(true);
List <TemperatureTable> TempList = new List<TemperatureTable >();
for (int i = 0; i < rows; i++)
{
TemperatureTable dummy = new TemperatureTable() { ID = i, TemperatureCelcius = 30,
DateTime = DateTime.Now, TotalMemory = totalMemory };
TempList.Add(dummy);
}
return TempList;
}As noted in the initial issue, you need to add property public long TotalMemory { get; set; } to public class TemperatureTable if returning the memory as a property (I added it to the Model saved to the database in the path that saves the temperature to have a record of the memory used at each save. However, as demonstrated by the HTTP GET endpoint that returns dummy data, the logging to SQLite and reading SQLIte don't contribute to the significant memory leak seen in Maple.
alexischr
bryancostanich
halyssonJr
adrianstevens
Describe the bug Application returns list of JSON serializable objects to Maple to send to HTTP client in response to HTTP GET results in a memory leak.
To Reproduce Steps to reproduce the behavior:
Add following methods to MeadowApp.cs to aid uniform data output
Add Console.WriteLine to GetTemperatureLogs() method to call above methods and output memory used.
Add additional end point that returns data without calling SQLite
Add similar console lines to the SaveReading method in DatabaseManager.cs to confirm no memory leak during saving
Expected behavior Total allocated Memory should not increase with each call to either endpoint. Note that the objects in the list returned to Maple would only be released after the data is serialised.
Screenshots Confirm that saving data to SQLite does not leak memory by checking does not increase at "done!" In this example the memory is +/- 1183864 (small variation ok)
Do HTTP Get to dummy end point that does not call SQLite to confirm the memory leak is in Maple and not the memory allocated at the "DTO" line and then at subsequent saves
Note at the next save and other saves that follow, some of the memory is released, but not all as total memory returns to +/- 1285256 and not near the original 1183864 above.
Doing additional HTTP GET will step up the allocated memory
and the additional memory is not released, even if the app runs for "long" time.
Developer tools (please complete the following information as best as you can):
Meadow (please complete the following information as best as you can): Connecting to Meadow on COM6 Meadow by Wilderness Labs Board Information Model: F7Micro Hardware version: F7FeatherV2 Device name: MeadowF7
Hardware Information Processor type: STM32F777IIK6 ID: 22-00-26-00-11-51-36-30-33-33-37-33 Serial number: 335D335F3036 Coprocessor type: ESP32 MAC Address - WiFi: 94:B9:7E:91:F4:0C
Firmware Versions OS: 0.9.4.0 Mono: 0.9.4.0 Coprocessor: 0.9.4.0
Done!
Additional context Uses Clima Hack Kit sample application as base.