search

WildfireRomeo / WildfireFemaleGenderMod

A Fabric Minecraft Mod - Minecraft's Most Popular Female Gender Mod!
https://modrinth.com/mod/female-gender
GNU Lesser General Public License v3.0
106 stars 62 forks source link

Fix Fabric hurt sounds requiring the mod server-side #132

Closed celestialfault closed 1 year ago

celestialfault commented 1 year ago

Adds client-sided hurt sounds on Fabric; fixes #83, and supersedes the hurt sound half of #117

An important difference between this and the Forge hurt sound implementation, is that while Forge replaces the hurt sound, this plays over top the vanilla hurt sound; this was done as the vanilla hurt sound may provide important context for how a player is taking damage, which could be especially helpful for players with poor eyesight.

The subtitle was also removed as a result of this playing over top the vanilla sound, as it doesn't provide any extra information that the player wouldn't already have from the vanilla subtitle.

Kichura commented 1 year ago

LGTM although one question: Why was the female hurt translation text removed or is that no longer a requirement?

celestialfault commented 1 year ago

Why was the female hurt translation text removed or is that no longer a requirement?

This was mentioned in the PR itself:

The subtitle was also removed as a result of this playing over top the vanilla sound, as it doesn't provide any extra information that the player wouldn't already have from the vanilla subtitle.