search

WildfireRomeo / WildfireFemaleGenderMod

A Fabric Minecraft Mod - Minecraft's Most Popular Female Gender Mod!
https://modrinth.com/mod/female-gender
GNU Lesser General Public License v3.0
106 stars 62 forks source link

Make it so other modloaders can detect our network channels #178

Closed pupnewfster closed 1 week ago

pupnewfster commented 9 months ago

I tested with this set of changes in #173 against my local branch of the NeoForge port to 1.20.4, and this allows for NeoForge to see that fabric can handle the packets and send sync packets to a fabric server/client. For some reason it seems like Fabric doesn't think the NeoForge end has the channels, so we don't actually send sync data back. But as I don't really know anything about fabric's networking, or if maybe it is a bug in how NeoForge sends stuff I am not looking into it in great detail right now. But basically this PR seems to allow for partial syncing when in a cross modloader environment, if anyone who knows more about how fabric does networking wants to give some input on why it behaves strangely or anything it definitely would be appreciated.

WildfireRomeo commented 1 week ago

Closing this PR since it's outdated and was superseded in another PR for a newer version.