Wildhoney / EmberDroplet

Ember.js HTML5 file uploading with drag & drop and image/file preview.
http://ember-droplet.herokuapp.com/
MIT License
197 stars 31 forks source link

Front end file size validation #80

Closed mattboldt closed 9 years ago

mattboldt commented 9 years ago

disregard the previous commits... I had a requestType property before I realized there was a dropletOptions object.

Wildhoney commented 9 years ago

Excellent addition! :+1: Although is there any chance we could bundle the filesizeLimit as part of the options configuration to be consistent?

mattboldt commented 9 years ago

Given this logic, the mimeTypes should also be in there.

On Jan 14, 2015, at 6:24 PM, Adam Timberlake notifications@github.com wrote:

Excellent addition! Although is there any chance we could bundle the filesizeLimit as part of the options configuration https://github.com/macroplant/EmberDroplet/blob/file-size-validation/dist/ember-droplet.js#L160 to be consistent?

— Reply to this email directly or view it on GitHub https://github.com/Wildhoney/EmberDroplet/pull/80#issuecomment-70019692.

Wildhoney commented 9 years ago

I agree :+1:

Wildhoney commented 9 years ago

Thanks! :beers: All merged.