search

Wildhoney / Magento-on-Angular

Angular.js application using Magento as the backend API
361 stars 120 forks source link

Project name updated in readme file. #106

Closed vrkansagara closed 8 years ago

vrkansagara commented 8 years ago

Project name changed into readme file from Moa to the Magento on Angular. for better knowing in read me file.

vrkansagara commented 8 years ago

@Wildhoney Ping on this PR :+1:

aonic commented 8 years ago

Hi @vrkansagara this PR is confusing to me. The PR subject asks for changing the project name in the README, however, the actual changes in this PR are much more massive.

Perhaps you meant to separate this PR?

vrkansagara commented 8 years ago

Hi @aonic it's good to know that you are reviewing the code base. But want to tell you that have really done the code review or this PR #106 .

And As you said

Hi @vrkansagara this PR is confusing to me. The PR subject asks for changing the project name in >the README, however, the actual changes in this PR are much more massive.

I thing there is no massive found by my self till time I am writing this comment in README file. and I haven't made any request or changed the project name. I have just said to update the readme file.

Perhaps you meant to separate this PR? NO,

Can you look into the details.