Wildhoney / ngVideo

Modularised ~13KB HTML5 audio/video implementation using Angular.js
http://ng-video.herokuapp.com/
MIT License
227 stars 57 forks source link

bower install does not include CSS/imagery needed to render videos as shown in README #23

Closed slj closed 9 years ago

slj commented 9 years ago

After installing via bower, I followed the basic instructions to get a video up, adding a controls section for play and pause. Thankfully, my video rendered, but Play and Pause controls only appeared as text under the video, to the left. Not seeing any CSS in the dist folder, I grabbed the default.css from the example provided in this repo and got a little farther (shadowed box around video, video size scaling as browser scales), but the Play and Pause texts still appear:

ngvideo txtctrls

I prefer to see them appear as icons, the way they appear in your README, for example:

https://camo.githubusercontent.com/bd8fa4b0847131a53cad59221c29b2683e4d763c/687474703a2f2f692e696d6775722e636f6d2f506f46386a37302e706e67

Wildhoney commented 9 years ago

ngVideo intentionally doesn't ship with any styles, because it's a module that you build from the ground upwards using the modules you want.

Saying that though, if you were to just copy and paste the example's CSS, as you have done, then there's no reason why it wouldn't apply the icons, and show the text. There is no actual text for the buttons in the example:

<section vi-controls class="controls">
    <span vi-controls-play title="Play" class="glyphicon glyphicon-play"></span>
    <span vi-controls-pause title="Pause" class="glyphicon glyphicon-pause"></span>
</section>
slj commented 9 years ago

Aha. My Play/Pause definitions did not include the class attribute. I apologize.

Wildhoney commented 9 years ago

Ah! :+1: Please let me know if you need anything else.