search

Wildhoney / ngVideo

Modularised ~13KB HTML5 audio/video implementation using Angular.js
http://ng-video.herokuapp.com/
MIT License
227 stars 60 forks source link

Alive? #25

Closed chrisghardwick closed 8 years ago

chrisghardwick commented 9 years ago

Is this project still alive?

The example has some problems: The vendor files for bootstrap, angularjs and common.js are missing.

I don't want to utilize a dead project.

Thanks!

Wildhoney commented 9 years ago

Yep, it's still alive :+1: if you want to submit a PR for those, then please by all means.

chrisghardwick commented 9 years ago

Thanks. Let me get up and running on the project.

Wildhoney commented 9 years ago

It also has an issue that it communicates to the directive through a service, which is a singleton, rather than the directive's interface. I'm currently in the progress of refactoring this. Although it won't cause any issues unless you have more than one video element on the page.

chrisghardwick commented 9 years ago

I might be missing something, but I downloaded the source and the components are missing. I was expecting to see the directives mentioned in the documentation in the Components folder (https://github.com/Wildhoney/ngVideo/tree/master/components) or in the distributable: https://github.com/Wildhoney/ngVideo/blob/master/dist/ng-video.js custom folder: https://github.com/Wildhoney/ngVideo/tree/master/dist/custom

Specifically I was looking for buffer, controls, etc. directives.

Is there something I missing here?

Wildhoney commented 8 years ago

Sorry — they should be there now.