search

Wildhoney / ngVideo

Modularised ~13KB HTML5 audio/video implementation using Angular.js
http://ng-video.herokuapp.com/
MIT License
227 stars 57 forks source link

move bootstrap and angular-mocks to devDependencies #33

Closed skwakman closed 9 years ago

skwakman commented 9 years ago

Bootstrap and angular-mocks are not required for the general function of ngVideo. Moving these dependencies to devDependencies prevents other projects from accidentally adding these components to their own distribution.

Wildhoney commented 9 years ago

Agreed :+1: Thanks.

caioiglesias commented 9 years ago

Can't bootstrap just get removed entirely?

Wildhoney commented 9 years ago

Bootstrap's used in the example only – no harm in keeping it in devDependencies :+1:

caioiglesias commented 9 years ago

Got it. I said it because it injects the bootstrap css on my live reloads messing up my previous styles. Had to manually remove it from bower and update.