Wildhoney / ngVideo

Modularised ~13KB HTML5 audio/video implementation using Angular.js
http://ng-video.herokuapp.com/
MIT License
227 stars 60 forks source link

vi-playlist-video #8

Closed toddrimes closed 10 years ago

toddrimes commented 10 years ago

First of all, I want to say thank you for this awesome module. It's 98% what I need, so I'm very thankful.

I have it working great with a series of videos I set in my item controller and which the player plays through with no problem. But when I go to "render" the playlist under the player using exactly the code listed [here:https://github.com/Wildhoney/ngVideo#playlist], the playlist renders fine, but I get this error in my console: http://errors.angularjs.org/1.2.20/$injector/unpr?p0=aProvider%20%3C-%20a%20%3C-%20viPlaylistVideoDirective and clicking the items has no effect on the player.

What am I doing wrong?

Thank you, ~Todd

toddrimes commented 10 years ago

Hmm - also, the package.json says the module name is ["name": "ng-video"] but the BOWER.json says it's ["name": "ngvideo"](no dash). This seems to be confusing heroku when I try to commit my site to which I've just added this module.

toddrimes commented 10 years ago

I tried both ng-video and ngvideo in bower.json, but heroku didn't like either one. :(

I removed the module for now, but your advice still greatly appreciated.

~Todd

Wildhoney commented 10 years ago

Thanks Todd!

Unfortunately somebody had taken the ng-video namespace in Bower so I had to remove the hyphen. I don't think that's related to your original issue though. ng-video deploys to Heroku via Travis and shouldn't use the data in your .travis.yml file for specifying the app.

For the original issue, once you've deployed to Heroku then I could take a look? viPlaylistVideo is present in the dist file, so I can't imagine what's happening in your case.

toddrimes commented 10 years ago

Thank you, Adam. I finally got the module to install on heroku. The issue was an angular version-conflict between angular-bootstrap and ngvideo caused by my careless upgrade of bootstrap. So, (now at least) you can see the error I'm getting with the vi-playlist directive (in the console) at http://www.freedailyleader.com/#!/feeds/53a8a552fe93900200d11e84 .

I am injecting ngVideo into my app in /public/js/app.js with

angular.module('mean', ['ngCookies', 'ngResource', 'ngSanitize',

'ui.bootstrap', 'ui.router', 'mean.system', 'mean.articles', 'mean.feeds', 'doowb.angular-pusher','angularFileUpload','ngVideo']).

in my app.js, then using it my controller (/public/controllers/feeds.js) with:

angular.module('mean.feeds').controller('FeedsController', ['$scope',

'$http', '$timeout', '$stateParams', '$location', '$sce', 'Global', 'Feeds', 'Pusher','$upload',* 'video', function ($scope, $http, $timeout, $stateParams, $location, $sce, Global, Feeds, Pusher, $upload, *video) {

Is there something else I need to do? After reading the docs, I figured if the player was working, then the vi-playlist directive would also work.

Thank you in advance for your help! ~Todd

On Wed, Jul 23, 2014 at 1:24 AM, Adam Timberlake notifications@github.com wrote:

Thanks Todd!

Unfortunately somebody had taken the ng-video namespace in Bower so I had to remove the hyphen. I don't think that's related to your original issue though. ng-video deploys to Heroku via Travis and shouldn't use the data in your .travis.yml file for specifying the app.

For the original issue, once you've deployed to Heroku then I could take a look? viPlaylistVideo is present in the dist file, so I can't imagine what's happening in your case.

— Reply to this email directly or view it on GitHub https://github.com/Wildhoney/ngVideo/issues/8#issuecomment-49845840.

Wildhoney commented 10 years ago

That's interesting. Could you add the development version of Angular to see if the message is any more informative please?

toddrimes commented 10 years ago

Okay, thank you. Done: http://www.freedailyleader.com/#!/feeds/53a8a552fe93900200d11e84

~Todd

toddrimes commented 10 years ago

Adam:

It seems like this error is a common side-effect of JS minification, so I switched to the UN-minified version when I include ng-video.js and the error went away. Probably just something else in my grunt build, but I'm happy for now.

<script type="text/javascript" src="/lib/ngvideo/dist/ng-video.min

.js">

Thank you, ~Todd

On Thu, Jul 24, 2014 at 7:21 AM, Todd Rimes todd.rimes@gmail.com wrote:

Okay, thank you. Done: http://www.freedailyleader.com/#!/feeds/53a8a552fe93900200d11e84

~Todd

Wildhoney commented 10 years ago

I suspected it would be something like that. I've not had time to check today – sorry! But I will look later and try to find the source of the problem :thumbsup:

I thought I'd taken all the necessary precautions with the minification, but perhaps I forgot something...

toddrimes commented 10 years ago

Thank you, Adam!

Wildhoney commented 10 years ago

@toddrimes I found the cause and fixed it just now :beers: Thanks for raising it!