search

Wildsong / ol-react

React bindings for OpenLayers
MIT License
8 stars 2 forks source link

Any plan to add types #4

Open wuhland opened 5 years ago

wuhland commented 5 years ago

Curious to know if you have any plans to add openlayers Types to this?

brian32768 commented 5 years ago

Sure! ... except I am not sure what you mean by openlayers "Types". Educate me please! --Brian

On Wed, Sep 18, 2019 at 5:41 PM David Saeger notifications@github.com wrote:

Curious to know if you have any plans to add openlayers Types to this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Wildsong/ol-react/issues/4?email_source=notifications&email_token=AAP6RRBINQFKUMLCJRWSDCTQKLDBZA5CNFSM4IYFC332YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMI7OOA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP6RRCJZGSELQJ3ZSFFSBLQKLDBZANCNFSM4IYFC33Q .

-- Brian Wilson tel:707-827-0003

wuhland commented 5 years ago

Apologies that was not a very helpful comment. I meant typescript support. Seems like you have proptypes defined for many of these components which would help, curious if that is a place you see this project going ever.

brian32768 commented 5 years ago

Okay, added to task list: learn about typescript. The existing typescript is carried over from the original project so it's probably mostly wrong now.

On Sun, Sep 22, 2019, 5:18 PM David Saeger notifications@github.com wrote:

Apologies that was not a very helpful comment. I meant typescript support. Seems like you have proptypes defined for many of these components which would help, curious if that is a place you see this project going ever.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Wildsong/ol-react/issues/4?email_source=notifications&email_token=AAP6RRGRW4HBAL5YE574O6DQLADMDA5CNFSM4IYFC332YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JSPYI#issuecomment-533932001, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP6RRBLU7W24OABIOHATWLQLADMDANCNFSM4IYFC33Q .