Wilenty / 7zTC-7-ZIP-NanaZip-Theme-Changer

Easy-to-use 7-Zip/NanaZip manager for toolbar, file-types and icons.
https://wilenty.wixsite.com/links
232 stars 4 forks source link

Some Icons Don't Change #4

Closed JAK0723 closed 3 hours ago

JAK0723 commented 1 year ago

OS: Windows 11 Home, Version 22H2, build 22621.674 7-Zip Version: 22.01

I was able to correctly apply a toolbar theme, however when changing the filetype icons, some of them will not be applied. Specifically, the 7z, CAB, ISO, TAR, and ZIP icons. I've tried multiple different themes, including the default, but they all fail to change these filetype icons.

Here is the log file, I've also attached a screenshot showing the problem.

explorer_2022-10-15_18-54-09

Wilenty commented 1 year ago

Hello, please look at the first line in the log file (last line in the log, because it's reversed):

[...] On Windows 11 the icons may not be refreshed without OS restart!
[...] Rebuilding icons cache...

That's the problem with W11...

JAK0723 commented 1 year ago

I have restarted my computer, but the icons have not changed.

Wilenty commented 1 year ago

Okay, let me check the log-file line-by-line...

Wilenty commented 1 year ago

Sorry, but I don't see anything strange, or abnormal, in the log file...

Update results of: 7z.ico) log-line: 1066

[18:48:11,526] Successfully updated resource "0" of file "(...)\Windows 11\7z.ico". (OK)

CAB.ico) log-line: 800

[18:48:11,634] Successfully updated resource "7" of file "(...)\Windows 11\cab.ico". (OK)

ISO.ico) log-line: 762

[18:48:11,650] Successfully updated resource "8" of file "(...)\Windows 11\iso.ico". (OK)

TAR.ico) log-line: 572

[18:48:11,725] Successfully updated resource "13" of file "(...)\Windows 11\tar.ico". (OK)

ZIP.ico) log-line: 1028

[18:48:11,542] Successfully updated resource "1" of file "(...)\Windows 11\zip.ico". (OK)

So, maybe you will send me the updated 7z.dll file, or you can check the updated icons in the ResourceHacker: http://angusj.com/resourcehacker/ in the "Group Icon".

JAK0723 commented 1 year ago

OK, I've attached the 7z.dll file. I had to zip it, since GitHub doesn't seem to allow uploading DLL files in comments.

7z.zip

Wilenty commented 1 year ago

As I thought, they were changed correctly: unknown

So, you have to clear the icon-cache, because M$ changing the ways from release to release (and we can't get all the changes they did)...

Please try one of: 1) https://www.elevenforum.com/t/rebuild-icon-cache-in-windows-11.2049/

ie4uinit.exe -show

2) https://appuals.com/rebuild-icon-cache-windows-11/

cd /d %userprofile%\AppData\Local\Microsoft\Windows\Explorer
attrib –h iconcache_*.db
del iconcache_*.db start explorer

Maybe you will have to kill the "explorer.exe" in the task-manager, if so, please leave the task-manager running and reboot the computer from the task-manager (because new version of "explorer.exe" in Windows 11 holds the icons-cache files).

And please let me know.

JAK0723 commented 1 year ago

Neither of them appear to have worked. I did confirm that the iconcache files were deleted by checking with ls, but those same filetypes still the wrong icons.

Also, I had to change the to a - in the attrib –h iconcache_*.db command.

Wilenty commented 1 year ago

So, now I don't know how I can help you with that. Files were changed correctly, but the "explorer.exe" (Windows 11) still shows old icons. Maybe you will have to download the ResourceHacer and check the icons yourself? The "Icon Group" names you see in the previous message with quote of the log-file. Or, maybe you will have to open the task-manager, kill the "explorer.exe", clear cache and reboot the OS from the task-manager.

Now you know, why people won't use it (Windows 11) on work computers, because things that worked, works wrong, or won't work at all...

JAK0723 commented 1 year ago

I did kill explorer.exe before deleting the iconcache files. Though I had to use the shutdown -r command in the terminal, since it appears you can no longer restart the computer from the new task manager.

As you suggested, I checked the DLL with ResourceHacker and the icons all look correct as shown in the attached screenshot. I suppose this is some issue with Windows 11, as you mentioned. Oddly, this program did correctly change the filetype icons my Windows 11 desktop PC, it just doesn't work on my new Windows 11 laptop.

ResourceHacker_2022-10-15_20-48-17

Wilenty commented 1 year ago

My program tries to delete these icons-cache files on Windows 10/11, but not killing the "explorer.exe" to not scary the user...

For sure it's a problem with Windows 11, and you should report it on their forum (that they know it). Also, if you want, you can re-install the Windows from scratch, but I don't know if it won't break the warranty (of the new laptop), and if it helps.

I pin this issue to prevent future questions about this same problem. So, you can delete the log-file from first message (if you want).

DeCoded-Void commented 1 year ago

I had the same issue and I was able to fix it on Windows 11.

I used FileTypesMan to view the location of the icons that explorer was referencing and to see if the MIME types of the file are accurate.

In my case it was pointing to icons located in C:\Program Files\7-Zip\Icons

Manually replacing the icon files in that directory and restarting windows explorer fixed it for me however I could also fix it by editing the icon location in the program I just mentioned.

Wilenty commented 1 year ago

Hello @DeCoded-Void, sorry for late reply.

I don't change any associations for 7-ZIP. I only adding the icon associations for NanaZip on the installation stage, because they are missing.

Can I ask how you installed the 7-ZIP, i.e. via my program, or via original installer?

Also, can you check the icons associations before using my program, and after it?

I realize that people like the "fresh view" in Windows 11, but (unfortunately) the Windows 11 is still in the testing stage, so I don't use it.

I tested my program on Windows XP with 7-ZIP, because NanaZip does not work on XP, and on Windows 7/10 with 7-ZIP/NanaZip.

Greetings, Wilenty

Wilenty commented 1 year ago

By the way.

If you will view any of the original 7-ZIP installers: https://7-zip.org/a/7z2201-x64.exe https://7-zip.org/a/7z2201.exe https://7-zip.org/a/7z2201-arm64.exe ( also mine repacks: https://github.com/Wilenty/7-Zip-X64-X86-with-Extracting-NSIS-script ) you will not see the folder "icons" inside it, so, I don't know from where it comes on Windows 11...

DeCoded-Void commented 1 year ago

I downloaded it using the original installer, specifically the 64-bit version from 7-zip.org while I was in Windows 10 and I used the original 7zTM. I upgraded to Windows 11 sometime earlier this year or last year.

I reused the program with a new icon pack since the aesthetic was clashing with windows 11 icons, but with no success, so I went browsing and found this repository and had no luck from that either.

A screenshot of the dll file from Resource Hacker and FileTypesMan: Screenshot 2022-12-27 005319

A thing to note is that even though the dll file was changed, I still had to point to the directory the icon is in or replace the referenced icon.

Wilenty commented 1 year ago

A thing to note is that even though the dll file was changed, I still had to point to the directory the icon is in or replace the referenced icon.

I can find and fix the icons associations in the OS registry, but I don't know if it's a good idea. Also I can copy the icon files to that "(...)\icons" folder, but then you will have the icons twice (in that DLL file and separately in the "(...)\icons" folder), if the "(...)\icons" directory exists (because I don't know if it's a Windows 11 bug or feature).

Can you help me out how to solve this problem? Because I really have no idea why it does not work only on Windows 11, but works without any problem on all other OS's.

Greetings, Wilenty

Wilenty commented 1 year ago

Hello all. Probably I have found simple as possible solution to solve the problem with icons associations in Windows 11.

For first open the 7-ZIP program, and click in the top menu: Tools -> Options (*if you want to change the icons associations for all users - execute 7-ZIP File Manager with Admin Rights)

If you don't had any program installed that can manage the compression icons associations, then you will see something like this: 01

If you want to change all icons for 7-ZIP for yourself, just click the left plus (+) above the list of the icons until you will see 7-ZIP in the first column, and click Apply / OK. 03

If you want to change all icons for 7-ZIP for all users*, just click the right plus (+) above the list of the icons until you will see 7ZIP in the second column, and click Apply / OK. 04

If you want to change single icon for 7-ZIP for yourself (I used rar in below screenshot) click on the middle column in the rar line until you will see 7-ZIP in the middle column, and click Apply / OK. 06

If you want to change single icon for 7-ZIP for all users* (I used rar in below screenshot) click on the right column in the rar line until you will see 7-ZIP in the right column, and click Apply / OK. 07

But, if the above solution does not change anything, please re-install 7-ZIP.

By the way, if this same problem with icons associations will happens to NanaZip, please re-install or update the NanaZip, because only the installation adds the icons associations for NanaZip.

Happy New Year!

DeCoded-Void commented 1 year ago

I can confirm this on my Windows 11 PC, changing the association from that menu worked with changing individual icons.

I originally installed 7-zip without any associations since I didn't want 7-zip to interfere with some file types.

Wilenty commented 1 year ago

Thank you for the confirmation @DeCoded-Void. :)

JAK0723 commented 1 year ago

Sorry for the late response, I haven't had much of a reason to use my laptop until recently.

I can confirm that changing the file associations did fix the icons, somewhat. Though changing the associations through 7-ZIP didn't work properly. Instead, I had to change the default program for the different file types to 7-ZIP though Windows' "open-with" > "always" dialog.