Closed albertodonato closed 7 years ago
I fixed conflicts with master, please consider merging.
Thanks for your PR, but I don't think this is the right approach.
ag-arguments
no longer a custom will break configurations for users who have customised it.However, I agree that ag-arguments
is brittle. Perhaps we should assert that we always have the minimum required arguments.
I hope you understand. I'm sorry for not communicating sooner.
@Wilfred, thanks for looking at the PR.
Agreed that changing ag-argument
not to be a custom would break users (I've reverted that change in my branch).
WRT case sensitive searches, adding a separate option for it doesn't really change the behavior compared to the current one. It's basically the default behavior to apply, and it's still possible to use the prefix to be prompted with the ag command line and edit it before each run to toggle it (or any other command line switch).
FWIW the reason behind my change is to minimize the need for command-line customization, to reduce the risk of breaking if ag-arguments
is changed in the future.
Drop the ag-arguments custom (convertig it to an internal variable), in favor of explicit toggles for stats (
ag-search-stats
) and smart case (ag-smart-case
). This makes configurable options more explicit, reducing the risk of breaking search by twaking the command line.There are also a few cleanups on the logic to build the ag command line.