In shell-quote show the proper directory

Wilfred / ag.el

An Emacs frontend to The Silver Searcher

http://agel.readthedocs.org/en/latest/

525 stars 61 forks source link

In shell-quote show the proper directory #131

Closed chmouel closed 7 years ago

chmouel commented 7 years ago

Default directory is properly configured to what the used was specifying but we were showing only "." when showing or executing the command. Let show the proper desired directory.

coveralls commented 7 years ago

Coverage remained the same at 19.188% when pulling 5209a49d3f7e3be33938d23e57a3c3954442810d on chmouel:patch-1 into 754d0fea35059c583b9613c7924cebba74fe1319 on Wilfred:master.

Wilfred commented 7 years ago

Thanks for your PR!

What's the goal here? Is this a bug fix, or a UI improvement? We do have the directory in the mode line already.

chmouel commented 7 years ago

this is mostly a UI improvement, since the directory that is displayed currently doesn't reflect the actual tested directory

Wilfred commented 7 years ago

Thanks for putting in the time to send a PR, but I don't think this is right for ag.el. We already have the current directory in the mode line, and we abbreviate it (so ~/foo rather than /home/wilfred/foo) for example. The command in the results buffer is already long, and we'd need to test it on windows as it's changing the command used.

I'd be open to adding a separate line to the results buffer, but I don't think changing the command used is the right approach.