search

Wilfred / ag.el

An Emacs frontend to The Silver Searcher
http://agel.readthedocs.org/en/latest/
525 stars 61 forks source link

Regression: master doesn't highlight results #162

Open joca-bt opened 4 years ago

joca-bt commented 4 years ago

I've updated from 0.47 to master and the results are no longer highlighted in *ag search* buffer.

My settings:

(setq ag-highlight-search t
      ag-reuse-buffers t)

ag command from *ag search* buffer: "ag" "--vimgrep" "--literal" "--group" "--line-number" "--column" "--color" "--color-match" "30;43" "--color-path" "1;32" "--smart-case" "--stats" "--" "ivy" "."

If I revert to 0.47 they're highlighted once again.

ag command in 0.47: "ag" "--color" "--color-match" "30;43" "--literal" "--line-number" "--smart-case" "--nogroup" "--column" "--stats" "--" "ivy" "."

I'm on 26.2 on Windows.

ag version 2.2.0

Features:
  +jit +lzma +zlib
joca-bt commented 4 years ago

After some debugging it looks like --vimgrep is the culprit.

What's the reasoning behind using this flag? I've been using this package for a few years on Windows and never experienced https://github.com/Wilfred/ag.el/issues/97.

Also, the flag is preventing ag-group-matches to do anything, since with it matches are never grouped.

Wilfred commented 4 years ago

ag.el is only lightly maintained these days, as I'm using deadgrep now. If you can suggest why removing --vimgrep will work, I'm happy to accept a PR. Perhaps it's a native window vs cygwin issue?

Until #101 there were several reports of bad highlighting: #97, and #121.

joca-bt commented 4 years ago

Wasn't aware o deadgrep, will give it a try.